Skip to content

Add bazel support for google benchmark #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 7, 2025

Conversation

GuillaumeLagrange
Copy link
Contributor

No description provided.

Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Instrumentation Performance Report

Merging #8 will create unknown performance changes

Comparing cod-815-bazel-support-for-c-integration (bf30684) with main (b6cbff9)

Summary

🆕 42 new benchmarks
⁉️ 21 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ BarTest[MyFixture] 3.6 µs N/A N/A
⁉️ DoubleTest[MyTemplatedFixture, double] 3.5 µs N/A N/A
⁉️ FooTest[MyFixture] 3.6 µs N/A N/A
⁉️ IntTest[MyTemplatedFixture, int] 3.5 µs N/A N/A
⁉️ TestA[MyTemplate1, int] 3.5 µs N/A N/A
⁉️ TestB[MyTemplate2, int, double] 3.5 µs N/A N/A
⁉️ BM_Capture[int_string_test] 3.8 µs N/A N/A
⁉️ BM_Capture[int_test] 3.6 µs N/A N/A
⁉️ BM_StringCopy 3.9 µs N/A N/A
⁉️ BM_memcpy[4096] 3.6 µs N/A N/A
⁉️ BM_memcpy[512] 3.6 µs N/A N/A
⁉️ BM_memcpy[64] 3.6 µs N/A N/A
⁉️ BM_memcpy[8192] 3.6 µs N/A N/A
⁉️ BM_memcpy[8] 3.6 µs N/A N/A
⁉️ BM_rand_vector 3.6 µs N/A N/A
⁉️ BM_Template1[int] 3.6 µs N/A N/A
⁉️ BM_Template1_Capture[int_string_test] 3.7 µs N/A N/A
⁉️ BM_Template1_Capture[two_type_test, int, double] 3.7 µs N/A N/A
⁉️ BM_Template2[int, double] 3.7 µs N/A N/A
⁉️ BM_Template[int] 4.3 µs N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

Copy link

codspeed-hq bot commented Apr 30, 2025

CodSpeed Walltime Performance Report

Merging #8 will create unknown performance changes

Comparing cod-815-bazel-support-for-c-integration (bf30684) with main (b6cbff9)

Summary

🆕 42 new benchmarks
⁉️ 21 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ BarTest[MyFixture] < 1 ns N/A N/A
⁉️ DoubleTest[MyTemplatedFixture, double] < 1 ns N/A N/A
⁉️ FooTest[MyFixture] < 1 ns N/A N/A
⁉️ IntTest[MyTemplatedFixture, int] < 1 ns N/A N/A
⁉️ TestA[MyTemplate1, int] < 1 ns N/A N/A
⁉️ TestB[MyTemplate2, int, double] < 1 ns N/A N/A
⁉️ BM_Capture[int_string_test] < 1 ns N/A N/A
⁉️ BM_Capture[int_test] < 1 ns N/A N/A
⁉️ BM_StringCopy 10 ns N/A N/A
⁉️ BM_memcpy[4096] 231.1 ns N/A N/A
⁉️ BM_memcpy[512] 30 ns N/A N/A
⁉️ BM_memcpy[64] 6.1 ns N/A N/A
⁉️ BM_memcpy[8192] 469.9 ns N/A N/A
⁉️ BM_memcpy[8] 6.1 ns N/A N/A
⁉️ BM_rand_vector < 1 ns N/A N/A
⁉️ BM_Template1[int] < 1 ns N/A N/A
⁉️ BM_Template1_Capture[int_string_test] < 1 ns N/A N/A
⁉️ BM_Template1_Capture[two_type_test, int, double] < 1 ns N/A N/A
⁉️ BM_Template2[int, double] < 1 ns N/A N/A
⁉️ BM_Template[int] 9.8 ns N/A N/A
... ... ... ... ...

ℹ️ Only the first 20 benchmarks are displayed. Go to the app to view all benchmarks.

@GuillaumeLagrange GuillaumeLagrange requested a review from art049 May 2, 2025 11:18
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-815-bazel-support-for-c-integration branch 4 times, most recently from 2e8e019 to 6c5f9f1 Compare May 2, 2025 22:05
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, can you also include the clang format config file so we can unify this?

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-815-bazel-support-for-c-integration branch 3 times, most recently from 18b9422 to 76c4d24 Compare May 6, 2025 13:18
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-815-bazel-support-for-c-integration branch 6 times, most recently from dfdf0a3 to e3980c0 Compare May 6, 2025 13:43
@GuillaumeLagrange GuillaumeLagrange requested a review from art049 May 6, 2025 13:50
@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-815-bazel-support-for-c-integration branch 6 times, most recently from d2df26e to 0908713 Compare May 7, 2025 12:06
@GuillaumeLagrange
Copy link
Contributor Author

@art049 ready for merging if you're fine with it

@GuillaumeLagrange GuillaumeLagrange force-pushed the cod-815-bazel-support-for-c-integration branch from 0908713 to 352b991 Compare May 7, 2025 13:08
Copy link
Member

@art049 art049 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LLet's go 💪

@GuillaumeLagrange GuillaumeLagrange merged commit bf30684 into main May 7, 2025
7 of 8 checks passed
@GuillaumeLagrange GuillaumeLagrange deleted the cod-815-bazel-support-for-c-integration branch May 7, 2025 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants