Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use f-strings in CTS #3806

Merged
merged 5 commits into from
Jan 27, 2025
Merged

Use f-strings in CTS #3806

merged 5 commits into from
Jan 27, 2025

Conversation

clumens
Copy link
Contributor

@clumens clumens commented Jan 22, 2025

No description provided.

@clumens clumens requested a review from nrwahl2 January 22, 2025 21:31
@clumens clumens changed the title Use f-strings in CTS, too Use f-strings in CTS Jan 23, 2025
@clumens
Copy link
Contributor Author

clumens commented Jan 23, 2025

@waltdisgrace You might be interested in looking at this one too.

cts/cts-scheduler.in Show resolved Hide resolved
cts/cts-exec.in Outdated Show resolved Hide resolved
@clumens
Copy link
Contributor Author

clumens commented Jan 27, 2025

Added a patch on top to deal with the action_timeout spacing.

cts/cts-exec.in Outdated Show resolved Hide resolved
The self._action_timeout string had a space at the beginning and end,
which is why we could get away with not having spaces around it in
format strings later.  I think this is less clear than removing the
spaces from the variable and adding them to the format strings where
appropriate.
@clumens clumens merged commit cde0030 into ClusterLabs:main Jan 27, 2025
1 check passed
@clumens clumens deleted the more-f-strings branch January 27, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants