Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binutils 2.29 followup 2 #318

Closed
wants to merge 1 commit into from

Conversation

jnpkrn
Copy link
Contributor

@jnpkrn jnpkrn commented Aug 27, 2018

Preferably goes after #288.

@jnpkrn
Copy link
Contributor Author

jnpkrn commented Aug 27, 2018

Should note when PROTECTED became also the possible outcome
(i.e., since which binutils version/commit).

@jnpkrn
Copy link
Contributor Author

jnpkrn commented Sep 4, 2018

Figured out the just the first commit was not disputable, the one
I already merged: 3af6104.

tests: functional: make log_external accommodate line differences one
is actually superseded with the more systemic counterpart in #288.

So I left one I am now pretty much doubting on the second thought,
which the previous comment meant to target (I figured out the missing
info and put into the commit, though).

Reason I am doubting it is not needed (and even could possibly be
harmful) is because Fedora rebuilds using both 2.29.1 and 2.30 seems
to be happy without such a change...

I guess I'll do some more testing so I can close this PR with a piece
in mind.

@chrissie-c
Copy link
Contributor

Closed as not needed any more

@chrissie-c chrissie-c closed this Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants