-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
'configure show changed' includes deleted elements #470
base: master
Are you sure you want to change the base?
'configure show changed' includes deleted elements #470
Conversation
be8b4cf
to
2402173
Compare
ca626ad
to
d1b37ed
Compare
a830988
to
bf4f62d
Compare
4afbcd1
to
a914ce7
Compare
0305d48
to
75acf0a
Compare
75acf0a
to
abb1e16
Compare
abb1e16
to
1f62d18
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@liangxin1300 I don't really understand the change.
Shouldn't be the expected behaviour that the delete
command is shown after show changed
?
At least in the test is not shown...
Instead we print primitive d2 Dummy
. Is this what you want?
@arbulu89 , |
@arbulu89 maybe we could add |
That's OK for me, but I don't know if matches with that user expectation. He won't find any output like |
@arbulu89 I will collect suggestions from this user |
Problem:
Our user complain that after delete resource(before commit), 'crm configure show changed' not list the elements just deleted.
Solution:
So I append this line:
in
filter_objects
function, cibconfig.py file.Test:
I also append lines in
test/testcases/commit
:to test this scenarios.
Behave seems not suitable to test interactive scenarios.