Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev: ra: Show parameters more clearly #1733

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Mar 28, 2025

Changes for ra info output

  • Show ra name in headers
# new
ocf:heartbeat:IPaddr2 - Manages virtual IPv4 and IPv6 addresses (Linux specific version)
# original
Manages virtual IPv4 and IPv6 addresses (Linux specific version) (ocf:heartbeat:IPaddr2)
  • More obviously for the required parameter
# new
ip (string): *** Required *** IPv4 or IPv6 address
# original
ip* (string): IPv4 or IPv6 address
# new
debug (string): *** Deprecated *** Write debug information to given file
# original
debug (string): Write debug information to given file
# new
ip (string): *** Required; Obsoletes ipaddr *** IP address or hostname of fencing device
# original
ip* (string): IP address or hostname of fencing device
  • Don't show parameter as required, which deprecated
# new
ip (string): *** Required; Obsoletes ipaddr *** IP address or hostname of fencing device
ipaddr (string): *** Deprecated *** IP address or hostname of fencing device
username (string): *** Required; Obsoletes login *** Login name
login (string): *** Deprecated *** Login name
# original
ip* (string): IP address or hostname of fencing device
ipaddr* (string): IP address or hostname of fencing device
username* (string): Login name
login* (string): Login name
  • Show short description for FA
# new
stonith:fence_ifmib - Fence agent for IF MIB
# original
stonith:fence_ifmib
  • Show required parameters first, then others in alphabetical order

@liangxin1300 liangxin1300 force-pushed the 20250328_show_parameters_more_clear branch 5 times, most recently from dbff3e6 to 660de42 Compare April 2, 2025 07:26
@liangxin1300 liangxin1300 force-pushed the 20250328_show_parameters_more_clear branch from 660de42 to 3f71944 Compare April 2, 2025 07:34
@liangxin1300 liangxin1300 changed the title Dev: ra: Show parameters more clear Dev: ra: Show parameters more clearly Apr 2, 2025
@liangxin1300 liangxin1300 force-pushed the 20250328_show_parameters_more_clear branch from 3f71944 to 3a07161 Compare April 2, 2025 08:03
@liangxin1300 liangxin1300 marked this pull request as ready for review April 2, 2025 08:04
@liangxin1300 liangxin1300 force-pushed the 20250328_show_parameters_more_clear branch from 3a07161 to ea50b94 Compare April 2, 2025 08:10
@nicholasyang2022
Copy link
Collaborator

Too noisy. The original format, using * to denote required parameters is more readable.

@liangxin1300
Copy link
Collaborator Author

Too noisy. The original format, using * to denote required parameters is more readable.

I thought this could be unified with the format like *** Advanced Use Only *** and *** Automatically generated by pacemaker ***

@liangxin1300
Copy link
Collaborator Author

This PR also fix #1724

# crm_resource --show-metadata stonith:fence_virsh|grep "required=\"1\""|grep -v deprecated
    <parameter name="ip" unique="0" required="1" obsoletes="ipaddr">
    <parameter name="username" unique="0" required="1" obsoletes="login">
crm(live/alp-1)configure# primitive st_virsh fence_virsh
crm(live/alp-1)configure# commit
(unpack_config)         warning: Blind faith: not fencing unseen nodes
ERROR: st_virsh: required parameter "ip" not defined
ERROR: st_virsh: required parameter "username" not defined
Do you still want to commit  (y/n)?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants