Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[crmsh-4.6] Drop deprecated codes #1725

Merged

Conversation

liangxin1300
Copy link
Collaborator

@liangxin1300 liangxin1300 commented Mar 25, 2025

  • Dev: Drop node type normal
    It's been deprecated for a long time, and it's time to remove it.
  • Dev: Remove codes that include rhcs term

@liangxin1300 liangxin1300 changed the title Dev: Drop node type normal [crmsh-4.6] Dev: Drop node type normal Mar 25, 2025
Copy link

codecov bot commented Mar 25, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 66.94%. Comparing base (d93487b) to head (4225125).
Report is 3 commits behind head on crmsh-4.6.

Files with missing lines Patch % Lines
crmsh/rsctest.py 0.00% 2 Missing ⚠️
crmsh/ui_configure.py 0.00% 1 Missing ⚠️
crmsh/xmlutil.py 50.00% 1 Missing ⚠️
Additional details and impacted files
Flag Coverage Δ
integration 52.94% <50.00%> (ø)
unit 49.40% <37.50%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
crmsh/constants.py 100.00% <100.00%> (ø)
crmsh/parse.py 81.59% <100.00%> (ø)
crmsh/ra.py 53.91% <100.00%> (ø)
crmsh/ui_configure.py 46.62% <0.00%> (ø)
crmsh/xmlutil.py 69.20% <50.00%> (ø)
crmsh/rsctest.py 64.74% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@liangxin1300 liangxin1300 changed the title [crmsh-4.6] Dev: Drop node type normal [crmsh-4.6] Drop deprecated codes Mar 26, 2025
@liangxin1300 liangxin1300 requested a review from zzhou1 March 26, 2025 07:54
It's been deprecated for a long time, and it's time to remove it.
@liangxin1300 liangxin1300 force-pushed the 20250324_drop_node_normal branch from d765cf5 to 4225125 Compare March 28, 2025 02:06
@liangxin1300 liangxin1300 requested a review from Copilot March 28, 2025 02:08
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes deprecated support for "normal" node types and any references to "rhcs" codes, replacing them with "member" nodes instead.

  • Removed is_normal_node in favor of is_member_node and updated all references.
  • Adjusted resource tests and parameter checks to drop "rhcs" support.
  • Updated regex patterns and default constants to reflect the new "member" node type.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
crmsh/xmlutil.py Renamed is_normal_node to is_member_node
crmsh/ui_configure.py Updated node check accordingly
crmsh/rsctest.py Dropped "rhcs/" related logic and error messages
crmsh/ra.py Adjusted stonith parameter checks to exclude "rhcs"
crmsh/parse.py Updated regex and documentation for node types
crmsh/constants.py Changed default node type from "normal" to "member"
Files not reviewed (1)
  • doc/crm.8.adoc: Language not supported

@liangxin1300 liangxin1300 merged commit 81e4158 into ClusterLabs:crmsh-4.6 Apr 3, 2025
31 of 32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants