Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[crmsh-4.6] Dev: adds a new command $ crm check migration #1398

Open
wants to merge 1 commit into
base: crmsh-4.6
Choose a base branch
from
Open

[crmsh-4.6] Dev: adds a new command $ crm check migration #1398

wants to merge 1 commit into from

Conversation

aleksei-burlakov
Copy link
Contributor

@aleksei-burlakov aleksei-burlakov commented Apr 22, 2024 •
edited
Loading

This new command checks if the migration from sle15 to sle16 is safe.
(ref: PED-8270)

@aleksei-burlakov aleksei-burlakov force-pushed the sle16-migration branch 3 times, most recently from 25876f8 to 21b734b Compare May 6, 2024 11:53
@aleksei-burlakov aleksei-burlakov changed the title DRAFT: Dev: PED-8270 Dev: adds a new command $ crm check migration May 6, 2024
@codecov Codecov
Copy link

codecov bot commented May 6, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 44.44444% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 53.11%. Comparing base (73eaf02) to head (ec46647).
Report is 22 commits behind head on crmsh-4.6.

Files Patch % Lines
crmsh/ui_check.py 40.62% 19 Missing ⚠️
crmsh/ui_root.py 75.00% 1 Missing ⚠️
Additional details and impacted files 
@@              Coverage Diff              @@
##           crmsh-4.6    #1398      +/-   ##
=============================================
+ Coverage      52.92%   53.11%   +0.19%     
=============================================
  Files             79       80       +1     
  Lines          23951    24010      +59     
=============================================
+ Hits           12676    12754      +78     
+ Misses         11275    11256      -19

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@aleksei-burlakov aleksei-burlakov marked this pull request as ready for review May 6, 2024 12:18
@aleksei-burlakov aleksei-burlakov changed the title Dev: adds a new command $ crm check migration [crmsh-4.6] Dev: adds a new command $ crm check migration May 12, 2024
Dev: PED-8270
ec46647 
This commit adds a new command

$ crm check migration

Which checks if the migration from sle15 to sle16 is safe.
nicholasyang2022
nicholasyang2022 reviewed May 14, 2024
View reviewed changes
Copy link
Collaborator

@nicholasyang2022 nicholasyang2022 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is not important to check whether these supported packages are installed before os migration. For example, we don't need libknet1 until corosync is upgraded to 3, and upgrading corosync to 3 will pull in libknet1 automatically as a dependency.

It is more important to make sure that unsupported packages are not installed or not used. For example, the old SAP resource agent should not be installed or used in cib.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicholasyang2022 nicholasyang2022 nicholasyang2022 left review comments

@liangxin1300 liangxin1300 Awaiting requested review from liangxin1300

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksei-burlakov @nicholasyang2022