-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Homebrew recipe 498 #566
Homebrew recipe 498 #566
Conversation
@@ -115,7 +117,7 @@ Preparing for a release | |||
|
|||
$ git checkout -b release/flocker-${VERSION%.*} origin/release/flocker-"${VERSION%.*}" | |||
|
|||
#. Update the version number in the downloads in ``docs/gettingstarted/linux-install.sh`` and ``docs/gettingstarted/osx-install.sh``, as well as the two RPMs in ``docs/gettingstarted/tutorial/Vagrantfile`` (a total of 4 locations). | |||
#. Update the version number in the download in ``docs/gettingstarted/linux-install.sh``, as well as the two RPMs in ``docs/gettingstarted/tutorial/Vagrantfile``, and the Homebrew recipe in the `homebrew-flocker`_ repository (a total of 4 locations). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also explain that you have to update the sha1 checksum and how to do that.
|
||
.. code-block:: console | ||
|
||
alice@mercury:~/flocker-tutorial$ brew update | ||
alice@mercury:~/flocker-tutorial$ brew install python | ||
alice@mercury:~$ brew update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like this step should be in the block above, since it's what's required to address the Your Homebrew is outdated.
message reported by brew doctor
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we don't need to say this at all. brew doctor
already suggests it.
To update Homebrew, run `brew update`.
@@ -30,6 +30,10 @@ Software | |||
|
|||
- an up-to-date clone of the `Flocker repository <https://github.com/ClusterHQ/flocker.git>`_ | |||
|
|||
- an up-to-date clone of the `homebrew-tap repository <https://github.com/ClusterHQ/homebrew-tap.git>`_ | |||
|
|||
- Access to OS X |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Follow-up issue to remove this dependency at #574
Thanks @adamtheturtle I installed it on a fresh osx vm and it worked. Please replace the brew based sha checksum instructions with the commands above and then merge. And maybe open a separate pull request to get this merged into the 0.1 docs too (see #561) |
Fixes #498 (with ClusterHQ/homebrew-tap#1)