Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew recipe 498 #566

Merged
merged 10 commits into from
Aug 15, 2014
Merged

Homebrew recipe 498 #566

merged 10 commits into from
Aug 15, 2014

Conversation

adamtheturtle
Copy link
Contributor

@wallrj wallrj self-assigned this Aug 14, 2014
@@ -115,7 +117,7 @@ Preparing for a release

$ git checkout -b release/flocker-${VERSION%.*} origin/release/flocker-"${VERSION%.*}"

#. Update the version number in the downloads in ``docs/gettingstarted/linux-install.sh`` and ``docs/gettingstarted/osx-install.sh``, as well as the two RPMs in ``docs/gettingstarted/tutorial/Vagrantfile`` (a total of 4 locations).
#. Update the version number in the download in ``docs/gettingstarted/linux-install.sh``, as well as the two RPMs in ``docs/gettingstarted/tutorial/Vagrantfile``, and the Homebrew recipe in the `homebrew-flocker`_ repository (a total of 4 locations).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also explain that you have to update the sha1 checksum and how to do that.


.. code-block:: console

alice@mercury:~/flocker-tutorial$ brew update
alice@mercury:~/flocker-tutorial$ brew install python
alice@mercury:~$ brew update
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this step should be in the block above, since it's what's required to address the Your Homebrew is outdated. message reported by brew doctor.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we don't need to say this at all. brew doctor already suggests it.

To update Homebrew, run `brew update`.

@@ -30,6 +30,10 @@ Software

- an up-to-date clone of the `Flocker repository <https://github.com/ClusterHQ/flocker.git>`_

- an up-to-date clone of the `homebrew-tap repository <https://github.com/ClusterHQ/homebrew-tap.git>`_

- Access to OS X
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Follow-up issue to remove this dependency at #574

@wallrj
Copy link
Contributor

wallrj commented Aug 15, 2014

Thanks @adamtheturtle

I installed it on a fresh osx vm and it worked.

Please replace the brew based sha checksum instructions with the commands above and then merge.

And maybe open a separate pull request to get this merged into the 0.1 docs too (see #561)

@wallrj wallrj added accepted and removed review labels Aug 15, 2014
@wallrj wallrj assigned adamtheturtle and unassigned wallrj Aug 15, 2014
adamtheturtle added a commit that referenced this pull request Aug 15, 2014
@adamtheturtle adamtheturtle merged commit d939f1a into master Aug 15, 2014
@adamtheturtle adamtheturtle deleted the homebrew-recipe-498 branch August 15, 2014 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create a Homebrew recipe for flocker-cli
2 participants