Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Support longer runner image build timeouts #543

Merged
merged 2 commits into from
Apr 28, 2024

Conversation

kichik
Copy link
Member

@kichik kichik commented Apr 28, 2024

Support setting longer timeouts for image runner builds. Previously we used custom resources that are limited to 1 hour. Now we will use a wait handle with support for up to 8 hours (the maximum CodeBuild supports). We now also confirm the requested timeout is supported and fail early if it doesn't.

This doesn't affect:

  • AMI builds
  • Windows Docker image builds
  • Explicit AWS Image Builder builds (builderType: RunnerImageBuilderType.AWS_IMAGE_BUILDER)

Don't forget to set the builder timeout with:

const fargateX64Builder = FargateRunnerProvider.imageBuilder(stack, 'Fargate builder', {
  codeBuildOptions: {
    timeout: cdk.Duration.hours(8), // 8 hours is the max supported by CodeBuild
  },
});

Fixes #540

@mergify mergify bot merged commit 747c579 into main Apr 28, 2024
15 checks passed
@mergify mergify bot deleted the longer-image-build-timeout branch April 28, 2024 21:29
mergify bot pushed a commit that referenced this pull request Apr 28, 2024
This issue was not part of any release. It was caused by #543.

The image was rebuilt on deploys where nothing has changed due to inconsistent hashing. CDK tokens pointing to assets made their way into the hash components.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant