-
-
Notifications
You must be signed in to change notification settings - Fork 39
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
fix: No child with id: 'CodeBuild' or 'Infrastructure' (#493)
When a builder is created but not used, calling `failedImageBuildsTopic()` raises an exception. ``` No child with id: 'CodeBuild' ``` or ``` No child with id: 'Infrastructure' ``` For example, this would trigger the exceptions: ``` const app = new cdk.App(); const stack = new cdk.Stack(app, 'test'); const vpc = new ec2.Vpc(stack, 'vpc'); LambdaRunnerProvider.imageBuilder(stack, 'codebuild builder'); Ec2RunnerProvider.imageBuilder(stack, 'ec2 image builder', { vpc }); new GitHubRunners(stack, 'runners', { providers: [new LambdaRunnerProvider(stack, 'p1' /* not using builder on purpose */)], }).failedImageBuildsTopic(); app.synth(); ``` Fixes #490
- Loading branch information
Showing
3 changed files
with
37 additions
and
7 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters