Revision and improvement of the Console #289

TheMeinerLP · 2020-06-29T08:59:46Z

This pull request includes:

breaking changes
no breaking changes

Changes made to the repository:

Added a console module to manage console inputs
A dynamic console registry was implemented
Passwords can now be entered hidden in the console
Command inputs like CTRL+C can be intercepted.
JLine3 was used as basis
A command history was implemented
An automatic command completion was implemented
Commands can be highlighted
Console settings
Rework of setups system
Logging rework

Documentation of test results:

Tests have not yet been carried out, as it is still in development

Related issues/discussions:

This Pull Request is a part of issue #279

lgtm-com · 2020-08-25T10:33:38Z

This pull request fixes 3 alerts when merging 2056589 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-25T12:27:51Z

This pull request fixes 3 alerts when merging b16f9e2 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-25T14:24:53Z

This pull request fixes 3 alerts when merging 4a5caa2 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

GiantTreeLP

This PR is still in draft, so this is a preliminary review.

...ib/cloudnet-command/src/main/java/eu/cloudnetservice/cloudnet/v2/command/CommandManager.java

...p-lib/cloudnet-logging/src/main/kotlin/eu/cloudnetservice/cloudnet/v2/logging/CloudLogger.kt

cloudnet-app-lib/cloudnet-logging/pom.xml

.../cloudnet-logging/src/main/kotlin/eu/cloudnetservice/cloudnet/v2/logging/LoggingFormatter.kt

cloudnet-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/command/CommandDebug.java

cloudnet-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/command/CommandDelete.java

...net-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/setup/GetBukkitVersion.java

...er/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/setup/spigot/SetupSpigotVersion.java

pom.xml

lgtm-com · 2020-08-25T15:48:07Z

This pull request fixes 3 alerts when merging 7fdbbfe into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-25T16:42:15Z

This pull request fixes 3 alerts when merging cc207a8 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-26T20:30:17Z

This pull request fixes 3 alerts when merging 3ab2115 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-27T17:52:49Z

This pull request introduces 1 alert and fixes 3 when merging ec7d282 into 1a3da44 - view on LGTM.com

new alerts:

1 for Dereferenced variable is always null

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

lgtm-com · 2020-08-28T17:19:42Z

This pull request fixes 3 alerts when merging ba80c66 into 1a3da44 - view on LGTM.com

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition

GiantTreeLP

There is a lot to unpack. A lot of duplicate and similar code. A lot of code that's unnecessary. Please fix this and additionally your style settings.

...b/cloudnet-command/src/main/java/eu/cloudnetservice/cloudnet/v2/command/CommandExecutor.java

...ib/cloudnet-command/src/main/java/eu/cloudnetservice/cloudnet/v2/command/CommandManager.java

...ib/cloudnet-console/src/main/java/eu/cloudnetservice/cloudnet/v2/console/ConsoleManager.java

cloudnet-app-lib/cloudnet-logging/pom.xml

...b/cloudnet-command/src/main/java/eu/cloudnetservice/cloudnet/v2/command/CommandExecutor.java

cloudnet-master/src/main/java/eu/cloudnetservice/cloudnet/v2/master/network/NetworkManager.java

...c/main/java/eu/cloudnetservice/cloudnet/v2/master/network/packet/in/PacketInAuthHandler.java

...net-wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/setup/GetBukkitVersion.java

...wrapper/src/main/java/eu/cloudnetservice/cloudnet/v2/wrapper/setup/spigot/SpigotBuilder.java

ghost · 2020-09-29T12:12:59Z

DeepCode's analysis on #61bc15 found:

ℹ️ 2 minor issues. 👇
✔️ 2 issues were fixed.

Top issues

Description	Example fixes
Printing the stack trace of java.lang.InterruptedException. Production code should not use printStackTrace. Occurrences: NetworkConnection.java:100 NetworkConnection.java:107 NetworkConnection.java:146	🔧 Example fixes
Use valueOf instead of constructing a new java.lang.String. valueOf is more efficient due to caching of frequently requested values. Occurrences: ChatColor.java:42 ChatColor.java:63	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost · 2020-09-29T12:13:55Z

DeepCode's analysis on #b22c57 found:

ℹ️ 2 minor issues. 👇
✔️ 2 issues were fixed.

Top issues

Description	Example fixes
Printing the stack trace of java.io.IOException. Production code should not use printStackTrace. Occurrences: SetupCreateWrapper.java:60 SetupCreateWrapper.java:66 CloudConfig.java:140	🔧 Example fixes
Use valueOf instead of constructing a new java.lang.String. valueOf is more efficient due to caching of frequently requested values. Occurrences: ChatColor.java:42 ChatColor.java:63	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

GiantTreeLP · 2020-09-29T15:15:53Z

Really? Did you even my comment about AnsiColorReplacer.java? Did you even read your own code?

You are using a(Ansi.Attribute.RESET) for every color and it doesn't even come to your mind to just simplify all calls?

I'm referring to this commit: CloudNetService/CloudNet@b22c573
Please amend it.

Bumps [junit](https://github.com/junit-team/junit4) from 4.13 to 4.13.1. - [Release notes](https://github.com/junit-team/junit4/releases) - [Changelog](https://github.com/junit-team/junit4/blob/main/doc/ReleaseNotes4.13.1.md) - [Commits](junit-team/junit4@r4.13...r4.13.1) Signed-off-by: dependabot[bot] <[email protected]>

…ment/junit-junit-4.13.1 Bump junit from 4.13 to 4.13.1

🚧Add copyright/license headers into all source files

Remove Dytanic from files where it is not necessary or outright wrong.

Bumps `dependency.netty.version` from 4.1.52.Final to 4.1.53.Final. Updates `netty-transport-native-epoll` from 4.1.52.Final to 4.1.53.Final - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.52.Final...netty-4.1.53.Final) Updates `netty-transport-native-kqueue` from 4.1.52.Final to 4.1.53.Final - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.52.Final...netty-4.1.53.Final) Updates `netty-codec` from 4.1.52.Final to 4.1.53.Final - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.52.Final...netty-4.1.53.Final) Updates `netty-handler` from 4.1.52.Final to 4.1.53.Final - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.52.Final...netty-4.1.53.Final) Updates `netty-codec-http` from 4.1.52.Final to 4.1.53.Final - [Release notes](https://github.com/netty/netty/releases) - [Commits](netty/netty@netty-4.1.52.Final...netty-4.1.53.Final) Signed-off-by: dependabot[bot] <[email protected]>

…ment/dependency.netty.version-4.1.53.Final Bump dependency.netty.version from 4.1.52.Final to 4.1.53.Final

Bumps [guava](https://github.com/google/guava) from 29.0-jre to 30.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Signed-off-by: dependabot[bot] <[email protected]>

GiantTreeLP

Please also take into consideration the comments made by Codacy

...et-logging/src/main/java/eu/cloudnetservice/cloudnet/v2/logging/color/AnsiColorReplacer.java

lgtm-com · 2021-04-13T21:00:58Z

This pull request introduces 1 alert and fixes 4 when merging ae7d8f2 into 71a732f - view on LGTM.com

new alerts:

1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

GiantTreeLP · 2021-04-15T18:02:29Z

I would say, after 10 months of development, this PR is ready to merge.

lgtm-com · 2021-04-15T21:59:35Z

This pull request introduces 1 alert and fixes 4 when merging 3be29f0 into 71a732f - view on LGTM.com

new alerts:

1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

lgtm-com · 2021-04-17T01:25:01Z

This pull request introduces 2 alerts and fixes 4 when merging 89b2f90 into 71a732f - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null
1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

lgtm-com · 2021-04-17T12:46:17Z

This pull request introduces 2 alerts and fixes 4 when merging 3e2ed30 into 71a732f - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null
1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

lgtm-com · 2021-04-19T17:27:49Z

This pull request introduces 2 alerts and fixes 4 when merging c748e95 into 71a732f - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null
1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

ghost · 2021-04-19T17:34:44Z

DeepCode's analysis on #8aa06c found:

ℹ️ 1 minor issue. 👇
✔️ 5 issues were fixed.

Top issues

Description	Example fixes
Printing the stack trace of java.lang.Exception. Production code should not use printStackTrace. Occurrences: SetupSpigotVersion.java:44 Document.java:228 Document.java:238	🔧 Example fixes

👉 View analysis in DeepCode’s Dashboard | Configure the bot

lgtm-com · 2021-04-19T17:43:44Z

This pull request introduces 2 alerts and fixes 4 when merging 8aa06c1 into 71a732f - view on LGTM.com

new alerts:

1 for Dereferenced variable may be null
1 for Potential input resource leak

fixed alerts:

2 for Potential output resource leak
1 for Constant loop condition
1 for Potential input resource leak

TheMeinerLP changed the title ~~WIP:~~ WIP: Revision and improvement of the Console Jun 29, 2020

TheMeinerLP changed the title ~~WIP: Revision and improvement of the Console~~ 🚧: Revision and improvement of the Console Jun 29, 2020

byRoadrunner marked this pull request as draft August 25, 2020 12:38

GiantTreeLP suggested changes Aug 25, 2020

View reviewed changes

TheMeinerLP marked this pull request as ready for review August 28, 2020 17:09

GiantTreeLP suggested changes Sep 28, 2020

View reviewed changes

CloudNetService deleted a comment from GiantTreeLP Sep 29, 2020

GiantTreeLP and others added 9 commits October 11, 2020 20:47

Add copyright/license headers into all source files

65dbdce

Merge pull request #312 from CloudNetService/dependabot/maven/develop…

52d6b4a

…ment/junit-junit-4.13.1 Bump junit from 4.13 to 4.13.1

Fix missing MANIFEST.MF file, rendering jar files invalid and corrupt

3697602

Merge pull request #313 from CloudNetService/license/headers

ef8cb90

🚧Add copyright/license headers into all source files

Update and add toString methods.

cd7e35f

Remove Dytanic from files where it is not necessary or outright wrong.

Merge pull request #314 from CloudNetService/dependabot/maven/develop…

7c491b7

…ment/dependency.netty.version-4.1.53.Final Bump dependency.netty.version from 4.1.52.Final to 4.1.53.Final

Bump guava from 29.0-jre to 30.0-jre

63d6d98

Bumps [guava](https://github.com/google/guava) from 29.0-jre to 30.0-jre. - [Release notes](https://github.com/google/guava/releases) - [Commits](https://github.com/google/guava/commits) Signed-off-by: dependabot[bot] <[email protected]>

TheMeinerLP added 9 commits April 11, 2021 15:39

Add a regex for IPv6 and IPv4 and checks for valid IPv4 and IPv6

cf4b1ce

Move regex to constants class and reuse in second class

df5ed47

Move basic value to a file and replace only changed values

c337c7f

Add a exists user check

fd2f286

Remove comment

27bfc67

Remove comment and fix by

1822957

Add based reference

ce6a899

Update ChatColor to Support HEX

dd43bde

Add background and foreground color replacing for command line

5ededa8

GiantTreeLP reviewed Apr 11, 2021

View reviewed changes

TheMeinerLP added 5 commits April 11, 2021 22:56

Improve code based on review

4fd6393

Improve code based on review

a7100d7

Remove import

ee99c0b

Fix formatting for ChatColor

9c5e6b4

Bump dependencies

ae7d8f2

TheMeinerLP added 2 commits April 15, 2021 23:25

Fix cloudnet console for rdy to merge

fa3521a

Fix help command

3be29f0

Fix many thing to make the working.

89b2f90

Little improvements

3e2ed30

Fix finally console

c748e95

Fix config for console

8aa06c1

GiantTreeLP merged commit 1e3af60 into CloudNetService:development Apr 19, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Revision and improvement of the Console #289

Revision and improvement of the Console #289

TheMeinerLP commented Jun 29, 2020 •

edited

Loading

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

GiantTreeLP left a comment

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 27, 2020

lgtm-com bot commented Aug 28, 2020

GiantTreeLP left a comment

ghost commented Sep 29, 2020

ghost commented Sep 29, 2020

GiantTreeLP commented Sep 29, 2020

GiantTreeLP left a comment

lgtm-com bot commented Apr 13, 2021

GiantTreeLP commented Apr 15, 2021

lgtm-com bot commented Apr 15, 2021

lgtm-com bot commented Apr 17, 2021

lgtm-com bot commented Apr 17, 2021

lgtm-com bot commented Apr 19, 2021

ghost commented Apr 19, 2021

lgtm-com bot commented Apr 19, 2021

Revision and improvement of the Console #289

Revision and improvement of the Console #289

Conversation

TheMeinerLP commented Jun 29, 2020 • edited Loading

Changes made to the repository:

Documentation of test results:

Related issues/discussions:

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

GiantTreeLP left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 25, 2020

lgtm-com bot commented Aug 26, 2020

lgtm-com bot commented Aug 27, 2020

lgtm-com bot commented Aug 28, 2020

GiantTreeLP left a comment

Choose a reason for hiding this comment

ghost commented Sep 29, 2020

DeepCode's analysis on #61bc15 found:

Top issues

👉 View analysis in DeepCode’s Dashboard | Configure the bot

ghost commented Sep 29, 2020

DeepCode's analysis on #b22c57 found:

Top issues

👉 View analysis in DeepCode’s Dashboard | Configure the bot

GiantTreeLP commented Sep 29, 2020

GiantTreeLP left a comment

Choose a reason for hiding this comment

lgtm-com bot commented Apr 13, 2021

GiantTreeLP commented Apr 15, 2021

lgtm-com bot commented Apr 15, 2021

lgtm-com bot commented Apr 17, 2021

lgtm-com bot commented Apr 17, 2021

lgtm-com bot commented Apr 19, 2021

ghost commented Apr 19, 2021

DeepCode's analysis on #8aa06c found:

Top issues

👉 View analysis in DeepCode’s Dashboard | Configure the bot

lgtm-com bot commented Apr 19, 2021

TheMeinerLP commented Jun 29, 2020 •

edited

Loading