OCI Artifact changes #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes the specf to adhere to OCI Artifact guidance. Adds a section about the tar layers. Some minor editing changes.And reproducibility section Signed-off-by: Gorkem Ercan <[email protected]>
caozhuozi
reviewed
Jan 15, 2025
|
|
||
| The image manifest of model artifacts follows the [OCI Image Manifest Specification][image-manifest] and adheres to the [artifacts guidance](https://github.com/opencontainers/image-spec/blob/main/artifacts-guidance.md). | ||
|
|
||
| ```JSON |
There was a problem hiding this comment.
It might be better to include the concret example in a dedicated section like Example Image Manifest Specification For Model Artifacts.
See a similar writing convention in image spec.
There was a problem hiding this comment.
makes sense, changed the order of things as well.
|
Thanks @gorkem! Generally looks good to me. There are lint errors though. |
Moves the manifest example to its own section. Signed-off-by: Gorkem Ercan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes the specification to adhere to OCI Artifact guidance. Adds a section about the tar layers and reproducibility. Editing changes to clarify.
fixes #17 and #23