Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #447: Changed format for exporting models to MetaGraphDef for Tensorflow #455

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

abhigyan7
Copy link
Contributor

This PR makes Fabrik export models as MetaGraphDef instead of Graphdef, which fixes #447. Doing this allows models built in Fabrik to be imported into Tensorflow seamlessly.

@Ram81
Copy link
Member

Ram81 commented Nov 16, 2018

@haabhi nice work, can you test whether all models in FabrikZoo which were working before are still working after the change or not.

@yashdusing
Copy link
Contributor

@haabhi are you going to make the changes in import_graphdef as well ?

@abhigyan7
Copy link
Contributor Author

@yashdusing Yes, I am doing that at the moment. I am working on importing both metagraphdefs and graphdefs so the model zoo models and models exported from fabrik both work.

@abhigyan7
Copy link
Contributor Author

@Ram81 @yashdusing
Now both binary and text metagraphdefs and graphdefs can be used to import tensorflow models in to fabrik. I have tested this with the prototxt models in the example/tensorflow directory and some random .meta and .pb files.

ide/tasks.py Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Models exported as graphdef protos for Tensorflow cannot be trained.
3 participants