-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #316 #416
base: master
Are you sure you want to change the base?
Fix #316 #416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove package-lock.json
, Can you also add for which framework capsule net export and import works in readme.md
package.json
Outdated
@@ -40,6 +40,7 @@ | |||
"eslint-plugin-jsx-a11y": "^1.4.2", | |||
"eslint-plugin-react": "^5.2.2", | |||
"file-loader": "^0.8.5", | |||
"json-loader": "^0.5.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not related to this issue, can you remove this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ram81 I am facing a problem. on my local machine when I use Capsnet.json to import model
number of parameters are right but on Fabrik canvas number of parameters are wrong.
Can you tell me where to look to resolve this issue?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@namish800 the logic for shape calculation is ide/utils/shapes.py
. For new layers that you added you can make changes to the shape calculation logic. If you have any doubts let me know.
*Added info for supported frameworks. *Added Length layer *Added MaskCapsule layer *Added Capsule layer *Added model to the modelZoo.js
@namish800 Can you also share a screenshot of imported model? |
@namish800 can you resolve the conflicts and fix the issue with number of parameters. |
@Ram81 I added the shape calculation logic for new layers. Now input and output shapes are correct but it is not counting number of parameters of only Capsule Layer now. |
I still can't figure out how does calculate_parameter function in ide/views.py works. Can you help me figure out how this function is calculating number of parameters. |
@namish800 can you test the export functionality of the model and mention it in readme also can you write import & export test for the same. |
@Ram81 I have tested the export functionality of the model and mentioned about it in the readme file. |
@namish800 yes you have to write tests there until we have a separate test suite for celery tasks. |
*Indicated about the same in README.md
*Added import and export test for Capsnet in tensorflow.
*Added CapsNet in model zoo as requested in issue #316 .
*Added support for CapsuleLayer under vision category.
*Added support for MaskCapsule layer and Length layer under Utility category.
*Added support for Squash layer under Activation category