-
Notifications
You must be signed in to change notification settings - Fork 15
feat: Update vep version #1567
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
feat: Update vep version #1567
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1567 +/- ##
===========================================
- Coverage 99.48% 99.30% -0.18%
===========================================
Files 40 40
Lines 1932 2019 +87
===========================================
+ Hits 1922 2005 +83
- Misses 10 14 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job 🌟 Code looks good to me, and great that the containers can build!
There's just a couple of things left that I would love to know.
First is if the workflows that use these containers can still finish successfully, it's probably enough to just test one workflow, as long as that workflow tests each way that the containers are used.
Then it would also be nice to understand a bit more about what the impact could be on the VCFs from updating cadd and vep.
- Is the format of the VCFs changed in any way?
- Is there new information added to the info fields?
- Has existing fields changed names?
- If anything has changed, can Scout still parse it?
- If there's new info, is there anything that would be relevant to ask Scout devs to add?
It can be difficult to understand all of the changes of course! But for one it would be nice to see if the second breakpoint in the SVs is now annotated for the fusion detection in Scout : )
@mathiasbio Addressing your comments:
The most relevant updates are:
![]() Has existing fields changed names? If anything has changed, can Scout still parse it? If there's new info, is there anything that would be relevant to ask Scout devs to add? |
|
Description
Closes #1556
Changed
Fixed
Documentation
Tests
Feature Tests
Pipeline Integrity Tests
.hk
file)Clinical Genomics Stockholm
Documentation
Panel of Normal specific criteria
User Changes
Infrastructure Changes
Validation criteria
Validation criteria to be added to validation report PR: [LINK-TO-VALIDATION-REPORT-PR from the validations repository]
Version specific criteria
Important
One of the below checkboxes for validation need to be checked
Checklist
Important
Ensure that all checkboxes below are ticked before merging.
For Developers
For Reviewers
conditions where applicable, with satisfactory results.