Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLOSES #553] Yes we talked and conversationRating not working. #555

Merged
merged 9 commits into from
May 14, 2024

Conversation

epixieme
Copy link
Collaborator

Closes 553 - Yes we talked and conversation rating not working

Detailed information:

The Yes We Talked button was missing onClick logic to handle progression to the next state. The same issue for the conversationRating component so I have added the logic and tested and it seems to work fine. Both now update the state and the conversation rating is now persisted from the database.

Closing issues:

closes #553

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@epixieme epixieme self-assigned this May 13, 2024
@epixieme epixieme linked an issue May 13, 2024 that may be closed by this pull request
@epixieme epixieme requested a review from Svenstar74 May 13, 2024 15:33
@epixieme epixieme changed the title Closes 553 - Yes we talked and conversation rating not working. [Closes #553] Yes we talked and conversation rating not working. May 13, 2024
@epixieme epixieme changed the title [Closes #553] Yes we talked and conversation rating not working. [Closes #553] Yes we talked and conversationRating not working. May 13, 2024
@Svenstar74 Svenstar74 changed the title [Closes #553] Yes we talked and conversationRating not working. [CLOSES #553] Yes we talked and conversationRating not working. May 13, 2024
@epixieme epixieme merged commit 6c2046e into develop May 14, 2024
1 check passed
@epixieme epixieme deleted the 553-yes-we-talked-not-working branch May 14, 2024 08:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Yes we talked not working
2 participants