Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Closes #491] - Fix UserbSharedSummary component being unable to display card details #505

Merged
merged 9 commits into from
Apr 21, 2024

Conversation

epixieme
Copy link
Collaborator

Detailed information:

[Closes #491] - Fix userbsharedsummary component being unable to display card details

  1. Changed the API on the userbsharedsummary component to the correct selected topics endpoint. This endpoint contains the data needed so that the details for each card can be displayed.
  2. Created a React query to fetch the data and state and then amended the cards and logic accordingly.
  3. Did some very simple styling. Added a margin bottom to each card. More styling needed in a new PR.

Closing issues:

Closes #491

Test plan (required)

  • The PR contains new PyTest unit/integration tests for any function or functional added.
  • The PR changes existing PyTest unit/integration tests to keep all tests up to date.
  • The PR does not lead to degradation in unit test coverage.
  • Project parts affected by changes in this PR was tested manually on your local (using Postman or in any other way). List everything you've tested below:
    • Part 1
    • Part 2

@epixieme epixieme self-assigned this Apr 17, 2024
@epixieme epixieme linked an issue Apr 17, 2024 that may be closed by this pull request
@epixieme epixieme requested a review from Svenstar74 April 17, 2024 13:26
@Svenstar74 Svenstar74 changed the title [Closes #491] - Fix userbsharedsummary component being unable to display card details [Closes #491] - Fix UserbSharedSummary component being unable to display card details Apr 17, 2024
@epixieme
Copy link
Collaborator Author

Resolved conflict in package.json

@Svenstar74 Svenstar74 merged commit 0bc72cf into develop Apr 21, 2024
1 check passed
@Svenstar74 Svenstar74 deleted the 491-fix-userbsharedsummary-not-loading-cards branch April 21, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UserBSharedSummary not loading cards
2 participants