Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor style cleanup, using f-strings #351

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Minor style cleanup, using f-strings #351

merged 3 commits into from
Dec 9, 2024

Conversation

brews
Copy link
Member

@brews brews commented Dec 5, 2024

Minor update converting % string formatting to use newer recommended f-string formatting. It's now a best practice. Should be easier to read.

This should have no change on package functionality.

This also bumps ruff to 0.8.x, which recommended the change when Dependabot tried to bump it in #348.

brews added 2 commits December 5, 2024 15:06
Convert old %-string formatting to use preferred f-strings. This update is required for ruff check 0.8.x.
@brews brews added enhancement New feature or request dependencies Pull requests that update a dependency file labels Dec 5, 2024
@brews brews self-assigned this Dec 5, 2024
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.91%. Comparing base (44cc7f7) to head (5cd83b2).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
src/dscim/utils/rff.py 33.33% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #351   +/-   ##
=======================================
  Coverage   68.91%   68.91%           
=======================================
  Files          15       15           
  Lines        1750     1750           
=======================================
  Hits         1206     1206           
  Misses        544      544           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brews brews requested a review from JMGilbert December 5, 2024 23:33
@brews
Copy link
Member Author

brews commented Dec 5, 2024

@JMGilbert tapping you for review on this, but I know you're busy. Appreciate your help. This should not take more than 5 minutes. It's a very small update to code syntax. Ruff was suggesting a change to keep up with Python best practices as the language evolves.

@brews brews marked this pull request as ready for review December 5, 2024 23:42
@JMGilbert
Copy link
Contributor

I'm surprised we had and % strings left. Happy to make the full official switch to f strings!

@brews brews merged commit c0638a6 into main Dec 9, 2024
3 of 4 checks passed
@brews brews deleted the style_cleanup branch December 9, 2024 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants