Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONEachRowWithProgress #334

Merged
merged 10 commits into from
Oct 5, 2024
Merged

JSONEachRowWithProgress #334

merged 10 commits into from
Oct 5, 2024

Conversation

slvrtrn
Copy link
Contributor

@slvrtrn slvrtrn commented Oct 1, 2024

Summary

Related to #241

  • Adds JSONEachRowWithProgress support with some additional type hints
  • Adds the Progress type and the isProgress type guard
  • Adds an example

Checklist

  • Unit and integration tests covering the common scenarios were added
  • A human-readable description of the changes was provided to include in CHANGELOG
  • For significant changes, documentation in https://github.com/ClickHouse/clickhouse-docs was updated with further explanations or tutorials

@slvrtrn slvrtrn requested a review from mshustov October 2, 2024 13:25
@slvrtrn
Copy link
Contributor Author

slvrtrn commented Oct 5, 2024

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

this is a lie.

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Oct 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@slvrtrn slvrtrn merged commit f2781ba into main Oct 5, 2024
@slvrtrn slvrtrn deleted the json-each-row-with-progress branch October 5, 2024 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mshustov mshustov mshustov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slvrtrn @mshustov