Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor clean up of repo #2950

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

Blargian
Copy link
Member

@Blargian Blargian commented Dec 24, 2024

Summary

Minor repo cleanup:

  • add a contributing folder to house anything contribution related. Move CODE_OF_CONDUCT.md to this folder.
  • add templates_and_guides directory to above mentioned folder to house any templates or guides, added a readme to explain the purpose.
  • move scripts in root to /scripts
  • move the image in the root to /images
  • delete pagerank.csv (not sure if this is needed or not?)
  • rename copyClickhouseRepoDocs.sh to copyClickHouseRepoDocs.sh
  • Fix up issues with copyClickHouseRepDocs.sh and autogenerate-settings.sh caused by moving the files.
  • Add basic error handling to the scripts above.

Checklist

@gingerwizard
Copy link
Contributor

@Blargian the change log generation script is causing the build to fail.

[copyClickHouseRepoDocs.sh] Copying completed successfully
[copyClickHouseRepoDocs.sh] Generate changelog
scripts/copyClickHouseRepoDocs.sh: line 36: ClickHouse/CHANGELOG.md: No such file or directory
[copyClickHouseRepoDocs.sh] An error occurred: Generating changelog
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
Error: Command "yarn new-build" exited with 1

Copy link
Contributor

@gingerwizard gingerwizard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see build log

@gingerwizard
Copy link
Contributor

@Blargian

Module not found: Error: Can't resolve '@site/docs/en/_snippets/_system_table_cloud.md' in '/vercel/path0/docs/en/operations/system-tables'
Module not found: Error: Can't resolve '@site/docs/en/_snippets/_system_table_cloud.md' in '/vercel/path0/docs/en/operations/system-tables'

@Blargian
Copy link
Member Author

@site/docs/en/_snippets/_system_table_cloud.md

Builds and runs okay locally. I'll need to check how things are set up on vercel, look at the logs there etc. I don't currently have any vercel deployment preview access. Will take a look next week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants