Skip to content

Versions: add 25.4 release #354

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Versions: add 25.4 release #354

wants to merge 1 commit into from

Conversation

qoega
Copy link
Member

@qoega qoega commented Apr 24, 2025

Thank You for Your Contribution!

We appreciate your effort and contribution to the project. To ensure that your Pull Request (PR) adheres to our guidelines, please ensure to review the rules mentioned in our contribution guidelines:

ClickHouse/ClickBench Contribution Rules

Thank you for your attention to these details and for helping us maintain the quality and integrity of the project.

https://pastila.nl/?0003ff97/41764f9a08e86602fa4c64b02a74bf60.html#Lb9hLCOhZvwDxpiE7zVZYg==

@amosbird
Copy link

Is the use_query_condition_cache feature enabled for HotRun?

@qoega
Copy link
Member Author

qoega commented Apr 25, 2025

Yes. It is enabled in 25.4 by default
https://github.com/ClickHouse/ClickHouse/blob/f787426b89ca7940630ecce55d0812b3db365beb/src/Core/SettingsChangesHistory.cpp#L88-L91

Users will see the same behaviour on warm queries in real-world scenarios so we decided to leave it enabled. It is not returning cached result and not using cached subquery so we decided to leave it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants