Implements Robin boundary condition for implicit free surface in the nonhydrostatic model #4166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glwagner
reviewed
Mar 5, 2025
| nonhydrostatic_pressure_solver(arch, grid::XYZRegularRG) = FFTBasedPoissonSolver(grid) | ||
| #nonhydrostatic_pressure_solver(arch, grid::XYZRegularRG) = FFTBasedPoissonSolver(grid) | ||
| nonhydrostatic_pressure_solver(arch, grid::XYZRegularRG) = | ||
| FourierTridiagonalPoissonSolver(grid) |
glwagner
reviewed
Mar 5, 2025
| @@ -43,7 +43,7 @@ end | |||
| Nz = size(grid, 3) | |||
|
|
|||
| # Using a homogeneous Neumann (zero Gradient) boundary condition: | |||
| @inbounds D[i, j, 1] = -1 / Δzᵃᵃᶠ(i, j, 2, grid) - Δzᵃᵃᶜ(i, j, 1, grid) * (λx[i] + λy[j]) | |||
| @inbounds D[i, j, 1] = -1 / Δzᵃᵃᶠ(i, j, 2, grid) - Δzᵃᵃᶜ(i, j, 1, grid) * (λx[i] + λy[j]) + (1 / (g * Δt^2)) | |||
There was a problem hiding this comment.
Nice. You'll have to hard code your g and Δt here since they aren't available. When we adapt this code to be merged into main we will design an interface that allows this to be input upon model construction. We will also have to forbid adaptive time-stepping, or better yet implement a way to update the pressure solver if the time-step changes.
|
hi @shriyafruitwala, #4169 is merged which should make it easier to set up the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.