This repository was archived by the owner on Mar 1, 2023. It is now read-only.
Use static range in Grad setproperty! #1537
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
bors try |
charleskawczynski
approved these changes
Sep 10, 2020
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Sep 10, 2020
1537: Use static range in Grad setproperty! r=mwarusz a=mwarusz # Description After #1458 I noticed a slowdown. This PR proposes a fix. Running ```julia --project=. experiments/AtmosLES/bomex_les.jl --monitor-timestep-duration 100steps``` I get Before: ``` ┌ Info: Wall-clock time per time-step (statistics across MPI ranks) │ maximum (s) = 1.5273617989999998e-02 │ minimum (s) = 1.5273617989999998e-02 │ median (s) = 1.5273617989999998e-02 └ std (s) = NaN ``` After: ``` Info: Wall-clock time per time-step (statistics across MPI ranks) │ maximum (s) = 1.1554147779999999e-02 │ minimum (s) = 1.1554147779999999e-02 │ median (s) = 1.1554147779999999e-02 └ std (s) = NaN ``` The fix relies on unexported `StaticArrays` API but JuliaArrays/StaticArrays.jl#474 makes me think that this is ok. 1538: Rename step (intrinsic func) r=charleskawczynski a=charleskawczynski # Description Closes #95. Co-authored-by: Maciej Waruszewski <[email protected]> Co-authored-by: Charles Kawczynski <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
After #1458 I noticed a slowdown. This PR proposes a fix.
Running
julia --project=. experiments/AtmosLES/bomex_les.jl --monitor-timestep-duration 100stepsI getBefore:
After:
The fix relies on unexported
StaticArraysAPI but JuliaArrays/StaticArrays.jl#474 makes me think that this is ok.I have
tests/runtests.jljulia .dev/climaformat.jl .For review by CLIMA developers
julia .dev/format.jlhas been run in a separate commit.