Skip to content

Commit

Permalink
Merge pull request #312 from CliMA/ck/fix_untested
Browse files Browse the repository at this point in the history 
Fix `n_calls_per_step`
  • Loading branch information
@charleskawczynski
charleskawczynski authored Sep 12, 2024
2 parents c1b1fac + 222188b commit 8a2bb9c
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 7 deletions.
2 changes: 1 addition & 1 deletion Project.toml
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name = "ClimaTimeSteppers"
uuid = "595c0a79-7f3d-439a-bc5a-b232dc3bde79"
authors = ["Climate Modeling Alliance"]
version = "0.7.35"
version = "0.7.36"

[deps]
ClimaComms = "3a4d1b5c-c61d-41fd-a00a-5873ba7a1b0d"
Expand Down
12 changes: 6 additions & 6 deletions ext/ClimaTimeSteppersBenchmarkToolsExt.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -39,16 +39,16 @@ n_calls_per_step(::CTS.ARS343, max_newton_iters) = Dict(
"post_implicit!" => 4,
"step!" => 1,
)
function n_calls_per_step(alg::CTS.RosenbrockAlgorithm{CTS.RosenbrockTableau{N}}) where {N}
function n_calls_per_step(alg::CTS.RosenbrockAlgorithm)
return Dict(
"Wfact" => 1,
"ldiv!" => N,
"T_imp!" => N,
"T_exp_T_lim!" => N,
"ldiv!" => CTS.n_stages(alg.tableau),
"T_imp!" => CTS.n_stages(alg.tableau),
"T_exp_T_lim!" => CTS.n_stages(alg.tableau),
"lim!" => 0,
"dss!" => N,
"dss!" => CTS.n_stages(alg.tableau),
"post_explicit!" => 0,
"post_implicit!" => N,
"post_implicit!" => CTS.n_stages(alg.tableau),
"step!" => 1,
)
end
Expand Down
1 change: 1 addition & 0 deletions src/solvers/rosenbrock.jl
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ struct RosenbrockTableau{N, SM <: SMatrix{N, N}, SM1 <: SMatrix{N, 1}}
"""m = b Γ⁻¹, used to compute the increments k"""
m::SM1
end
n_stages(::RosenbrockTableau{N}) where {N} = N

function RosenbrockTableau(α::SMatrix{N, N}, Γ::SMatrix{N, N}, b::SMatrix{1, N}) where {N}
A = α / Γ
Expand Down

2 comments on commit 8a2bb9c

@charleskawczynski
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JuliaRegistrator register

@JuliaRegistrator
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Registration pull request created: JuliaRegistries/General/115087

Tip: Release Notes

Did you know you can add release notes too? Just add markdown formatted text underneath the comment after the text
"Release notes:" and it will be added to the registry PR, and if TagBot is installed it will also be added to the
release that TagBot creates. i.e.

@JuliaRegistrator register

Release notes:

## Breaking changes

- blah

To add them here just re-invoke and the PR will be updated.

Tagging

After the above pull request is merged, it is recommended that a tag is created on this repository for the registered package version.

This will be done automatically if the Julia TagBot GitHub Action is installed, or can be done manually through the github interface, or via:

git tag -a v0.7.36 -m "<description of version>" 8a2bb9c339b7f7e506b4dcdee23df3c1c4951a4b
git push origin v0.7.36

Please sign in to comment.