Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigating benchmarks #997

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Investigating benchmarks #997

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bde16cd
Investigating benchmarks
ph-kev Jan 30, 2025
b8f2c12
Run: 2
ph-kev Jan 30, 2025
356ca49
Run 3
ph-kev Jan 31, 2025
adce17b
Run: 4
ph-kev Jan 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion experiments/benchmarks/bucket.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,9 +171,11 @@ MAX_PROFILING_TIME_SECONDS = 500
MAX_PROFILING_SAMPLES = 100
time_now = time()
timings_s = Float64[]
ClimaComms.device() isa ClimaComms.CUDADevice && import CUDA
while (time() - time_now) < MAX_PROFILING_TIME_SECONDS &&
length(timings_s) < MAX_PROFILING_SAMPLES
lprob, lode_algo, lΔt, lcb = setup_simulation()
ClimaComms.device() isa ClimaComms.CUDADevice && CUDA.device_synchronize()
push!(
timings_s,
ClimaComms.@elapsed device SciMLBase.solve(
Expand All @@ -192,11 +194,13 @@ std_timing_s = round(
sqrt(sum(((timings_s .- average_timing_s) .^ 2) / num_samples)),
sigdigits = 3,
)
# Runs: 4
@info "Num samples: $num_samples"
@info "Average time: $(average_timing_s) s"
@info "Max time: $(max_timing_s) s"
@info "Min time: $(min_timing_s) s"
@info "Standard deviation time: $(std_timing_s) s"
@info "Timings: $timings_s"
@info "Done profiling"

prob, ode_algo, Δt, cb = setup_simulation()
Expand Down Expand Up @@ -244,7 +248,7 @@ if ClimaComms.device() isa ClimaComms.CUDADevice
end

if get(ENV, "BUILDKITE_PIPELINE_SLUG", nothing) == "climaland-benchmark"
PREVIOUS_BEST_TIME = 0.477
PREVIOUS_BEST_TIME = 0.486
if average_timing_s > PREVIOUS_BEST_TIME + std_timing_s
@info "Possible performance regression, previous average time was $(PREVIOUS_BEST_TIME)"
elseif average_timing_s < PREVIOUS_BEST_TIME - std_timing_s
Expand Down
7 changes: 6 additions & 1 deletion experiments/benchmarks/land.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,9 +392,12 @@ MAX_PROFILING_TIME_SECONDS = 500
MAX_PROFILING_SAMPLES = 100
time_now = time()
timings_s = Float64[]
ClimaComms.device() isa ClimaComms.CUDADevice && import CUDA
while (time() - time_now) < MAX_PROFILING_TIME_SECONDS &&
length(timings_s) < MAX_PROFILING_SAMPLES
lprob, lode_algo, lΔt, lcb = setup_simulation()
ClimaComms.device() isa ClimaComms.CUDADevice && CUDA.device_synchronize()
ClimaComms.device() isa ClimaComms.CUDADevice && println("This should work!")
push!(
timings_s,
ClimaComms.@elapsed device SciMLBase.solve(
Expand All @@ -413,11 +416,13 @@ std_timing_s = round(
sqrt(sum(((timings_s .- average_timing_s) .^ 2) / num_samples)),
sigdigits = 3,
)
# Runs: 4
@info "Num samples: $num_samples"
@info "Average time: $(average_timing_s) s"
@info "Max time: $(max_timing_s) s"
@info "Min time: $(min_timing_s) s"
@info "Standard deviation time: $(std_timing_s) s"
@info "Timings: $timings_s"
@info "Done profiling"

prob, ode_algo, Δt, cb = setup_simulation()
Expand Down Expand Up @@ -465,7 +470,7 @@ if ClimaComms.device() isa ClimaComms.CUDADevice
end

if get(ENV, "BUILDKITE_PIPELINE_SLUG", nothing) == "climaland-benchmark"
PREVIOUS_BEST_TIME = 6.1
PREVIOUS_BEST_TIME = 6.35
if average_timing_s > PREVIOUS_BEST_TIME + std_timing_s
@info "Possible performance regression, previous average time was $(PREVIOUS_BEST_TIME)"
elseif average_timing_s < PREVIOUS_BEST_TIME - std_timing_s
Expand Down
4 changes: 4 additions & 0 deletions experiments/benchmarks/richards.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,9 +222,11 @@ MAX_PROFILING_TIME_SECONDS = 500
MAX_PROFILING_SAMPLES = 100
time_now = time()
timings_s = Float64[]
ClimaComms.device() isa ClimaComms.CUDADevice && import CUDA
while (time() - time_now) < MAX_PROFILING_TIME_SECONDS &&
length(timings_s) < MAX_PROFILING_SAMPLES
lprob, lode_algo, lΔt, lcb = setup_simulation()
ClimaComms.device() isa ClimaComms.CUDADevice && CUDA.device_synchronize()
push!(
timings_s,
ClimaComms.@elapsed device SciMLBase.solve(
Expand All @@ -243,11 +245,13 @@ std_timing_s = round(
sqrt(sum(((timings_s .- average_timing_s) .^ 2) / num_samples)),
sigdigits = 3,
)
# Runs: 4
@info "Num samples: $num_samples"
@info "Average time: $(average_timing_s) s"
@info "Max time: $(max_timing_s) s"
@info "Min time: $(min_timing_s) s"
@info "Standard deviation time: $(std_timing_s) s"
@info "Timings: $timings_s"
@info "Done profiling"

prob, ode_algo, Δt, cb = setup_simulation()
Expand Down
6 changes: 5 additions & 1 deletion experiments/benchmarks/snowy_land.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -403,9 +403,11 @@ MAX_PROFILING_TIME_SECONDS = 500
MAX_PROFILING_SAMPLES = 100
time_now = time()
timings_s = Float64[]
ClimaComms.device() isa ClimaComms.CUDADevice && import CUDA
while (time() - time_now) < MAX_PROFILING_TIME_SECONDS &&
length(timings_s) < MAX_PROFILING_SAMPLES
lprob, lode_algo, lΔt, lcb = setup_simulation()
ClimaComms.device() isa ClimaComms.CUDADevice && CUDA.device_synchronize()
push!(
timings_s,
ClimaComms.@elapsed device SciMLBase.solve(
Expand All @@ -424,11 +426,13 @@ std_timing_s = round(
sqrt(sum(((timings_s .- average_timing_s) .^ 2) / num_samples)),
sigdigits = 3,
)
# Runs: 4
@info "Num samples: $num_samples"
@info "Average time: $(average_timing_s) s"
@info "Max time: $(max_timing_s) s"
@info "Min time: $(min_timing_s) s"
@info "Standard deviation time: $(std_timing_s) s"
@info "Timings: $timings_s"
@info "Done profiling"

prob, ode_algo, Δt, cb = setup_simulation()
Expand Down Expand Up @@ -476,7 +480,7 @@ if ClimaComms.device() isa ClimaComms.CUDADevice
end

if get(ENV, "BUILDKITE_PIPELINE_SLUG", nothing) == "climaland-benchmark"
PREVIOUS_BEST_TIME = 6.5
PREVIOUS_BEST_TIME = 0.545
if average_timing_s > PREVIOUS_BEST_TIME + std_timing_s
@info "Possible performance regression, previous average time was $(PREVIOUS_BEST_TIME)"
elseif average_timing_s < PREVIOUS_BEST_TIME - std_timing_s
Expand Down
Loading