Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow n-band radiative transfer #1014

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Allow n-band radiative transfer #1014

wants to merge 8 commits into from

Conversation

Espeer5
Copy link
Collaborator

@Espeer5 Espeer5 commented Feb 5, 2025

Purpose

This PR extends our radiative transfer functionality from 2 bands (PAR and NIR) to an n-band scheme. This will allow pairing with ClimaAtmos which provides 16 bands. Represents step one towards #876.

This PR must be a large number of lines due to updating of all of the experiments and tests.

To-do

  • Update fundamental radiation structs
  • Update radiative transfer computations in models
  • Repair all experiments and tests to work with new scheme
  • Add a test for using up to 16 bands of radiation
  • Check benchmarks and long runs to ensure no significant regressions
  • Verify GPU compatibility is not broken

Content

  • Adds a tuple-based type for the discretization of the λ spectrum
  • All leaf & soil optics types are converted to tuple-valued fields
  • Uses solar irradiance curve to allocate incoming shortwave to radiation bands
    • Also to compute PAR quantities from spectral absorption for photosynthesis
  • Updates all tests and experiments to work with new structs / types

  • I have read and checked the items on the review checklist.

@Espeer5 Espeer5 added enhancement New feature or request breaking change labels Feb 5, 2025
@Espeer5 Espeer5 self-assigned this Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant