Add boundary fluxes terms to the soil jacobian when running with prescribed atmos #1011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kmdeck
commented
Feb 5, 2025
| topBC_op_water = topBC_op_heat | ||
| end | ||
| # Add term from top boundary condition before applying divergence | ||
| # Note: need to pass 3D field on faces to `topBC_op`. Interpolating `K` to faces |
There was a problem hiding this comment.
When you wrote "this is inefficient", why is that?
There was a problem hiding this comment.
@juliasloan25 do you recall what this was about?
kmdeck
changed the title
kmdeck
commented
Feb 5, 2025
juliasloan25
reviewed
Feb 5, 2025
src/integrated/land.jl
Outdated
| ρc = p.soil.sub_sfc_scratch | ||
| @. ρc = | ||
| volumetric_heat_capacity(p.soil.θ_l, Y.soil.θ_i, ρc_ds, earth_param_set) | ||
| ρc_sfc = ClimaLand.Domains.top_center_to_surface(ρc) |
There was a problem hiding this comment.
I think this is allocating - is there another scratch space we could use?
There was a problem hiding this comment.
oh! I think top_center_to_surface is OK - because it is just pulling out a view of the field.
src/integrated/soil_canopy_model.jl
Outdated
| ρc = p.soil.sub_sfc_scratch | ||
| @. ρc = | ||
| volumetric_heat_capacity(p.soil.θ_l, Y.soil.θ_i, ρc_ds, earth_param_set) | ||
| ρc_sfc = ClimaLand.Domains.top_center_to_surface(ρc) |
There was a problem hiding this comment.
same comment as above w.r.t. allocations
…ub.com/CliMA/ClimaLand.jl into kd/jacobian_boundary_flux_atmos_driven
kmdeck
added
Run benchmarks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds infrastructure for adding d(boundary flux)/dY to the Jacobian for the soil model when Atmos-Driven fluxes are used.
Currently sets the contributions to zero, no change in simulations are expected. I turned on the "run benchmarks" to see if there is any impact.
To-do
Content
Adds space to the cache for dLHFdT, dSHFdT, dGHFdT. Currently only the last one is updated/nonzero. The other two are set to zero
These terms will then be used in dFlux/dT dT/d rho e. We allocated space for those in the cache, but they are currently set to zero.
These terms are then added into the jacobian for the soil model.