Add high resolution clm data artifact #1007
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
from
09b5088 to
477838c
Compare
Sbozzolo
reviewed
Feb 4, 2025
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
from
51ae294 to
058042a
Compare
12 tasks
|
Looks good. Can we just be more precise in terms of the resolution. High vs low res is relative. Can we call it 0.125 instead? |
The name is now changed to "clm_data_0.125" |
braghiere
approved these changes
Feb 5, 2025
12 tasks
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
2 times, most recently
from
93b94dc to
ff7d319
Compare
Sbozzolo
reviewed
Feb 11, 2025
Comment on lines
23
to
26
| # scale in meters | ||
| element_scale = ClimaCore.Meshes.element_horizontal_length_scale(mesh) | ||
| return abs(lowres_scale - element_scale) < | ||
| abs(highres_scale - element_scale) |
There was a problem hiding this comment.
I think we want to check the distance between nodes, not elements. So you might want to use node_horizontal_length_scale instead
Sbozzolo
approved these changes
Feb 11, 2025
| ) | ||
| surface_space = domain.space.surface | ||
| surface_mesh = ClimaCore.Spaces.topology(surface_space).mesh | ||
| @test ClimaLand.use_lowres_clm(surface_mesh) == false |
There was a problem hiding this comment.
Suggested change
| @test ClimaLand.use_lowres_clm(surface_mesh) == false | |
| @test !(ClimaLand.use_lowres_clm(surface_mesh)) |
| ) | ||
| surface_space = domain.space.surface | ||
| surface_mesh = ClimaCore.Spaces.topology(surface_space).mesh | ||
| @test ClimaLand.use_lowres_clm(surface_mesh) == true |
There was a problem hiding this comment.
Suggested change
| @test ClimaLand.use_lowres_clm(surface_mesh) == true | |
| @test ClimaLand.use_lowres_clm(surface_mesh) |
| ) | ||
| surface_space = domain.space.surface | ||
| surface_mesh = ClimaCore.Spaces.topology(surface_space).mesh | ||
| @test ClimaLand.use_lowres_clm(surface_mesh) == false |
There was a problem hiding this comment.
Suggested change
| @test ClimaLand.use_lowres_clm(surface_mesh) == false | |
| @test !(ClimaLand.use_lowres_clm(surface_mesh)) |
| # test `use_lowres_clm` on the sphere domain, and then again with a sphere domain with 2x | ||
| # the horizontal resolution. Then repeat with plane domains. | ||
| surface_mesh = ClimaCore.Spaces.topology(surface_space).mesh | ||
| @test ClimaLand.use_lowres_clm(surface_mesh) == true |
There was a problem hiding this comment.
Suggested change
| @test ClimaLand.use_lowres_clm(surface_mesh) == true | |
| @test ClimaLand.use_lowres_clm(surface_mesh) |
Adds a higher resolution clm data artifact, named clm_data_0.125x0.125. The previous artifact is renamed to clm_data_0.9x1.25. The clm_data_folder_path function takes in the `lowres` flag as a kwarg, and returns the correct folder based on that. This also adds the `lowres` kwarg to the `clm_canopy_parameters` and `default_spatially_varying_soil_parameters` functions. The default value of `lowres` is determined by the `use_lowres_clm` function. If given a cubed sphere mesh, the function compares the results of ClimaCore.Meshes.element_horizontal_length_scale to the approximate horizontal scale of both clm data artifacts in meters. If given a rectilinear mesh, it does the same but in degrees. adjust test use node horizontal length scale
imreddyTeja
force-pushed
the
tr/add-high-res-clm-data
branch
from
ff7d319 to
081179c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Along with the accompanying ClimaArtifacts PR, this
closes #999
Content
Adds a higher resolution clm data artifact, named
clm_data_0.125x0.125. The previous artifact is renamed
to clm_data_0.9x1.25.
The clm_data_folder_path function takes in the
lowresflag as a kwarg, and returns the correct folder based on
that.
This also adds the
lowreskwarg to theclm_canopy_parametersanddefault_spatially_varying_soil_parametersfunctions. The default value of
lowresis determined by theuse_lowres_clmfunction. If given a cubed sphere mesh, the functioncompares the results of
ClimaCore.Meshes.element_horizontal_length_scaleto the approximate horizontal scale of both clm data artifacts
in meters. If given a rectilinear mesh, it does the same but in
degrees.