Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Remapper to FiniteDifferenceSpaces, update interpolate interface #2060

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Extend Remapper to FiniteDifferenceSpaces, update interpolate interface #2060

merged 1 commit into from
Jan 8, 2025

Conversation

charleskawczynski
Copy link
Member

@charleskawczynski charleskawczynski commented Oct 25, 2024 •
edited by Sbozzolo
Loading

Closes #2032

@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 2 times, most recently from 59fbe88 to 368ac55 Compare October 29, 2024 21:58
@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 5 times, most recently from e3c5f0b to 2553fe3 Compare November 14, 2024 16:25
@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 2 times, most recently from d951642 to 2ad3e18 Compare December 10, 2024 17:52
@Sbozzolo
Copy link
Member

Corresponding PR in ClimaDiagnostics

CliMA/ClimaDiagnostics.jl#99

@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 3 times, most recently from e9f0fa7 to b469e8d Compare December 10, 2024 20:54
@Sbozzolo Sbozzolo mentioned this pull request Dec 21, 2024
Merged
@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 2 times, most recently from b3492d1 to 6ec3488 Compare December 22, 2024 20:37
charleskawczynski
charleskawczynski commented Jan 3, 2025
View reviewed changes
Copy link
Member Author

@charleskawczynski charleskawczynski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some comments, I think that this is looking pretty good overall.

src/Remapping/distributed_remapping.jl Show resolved Hide resolved
src/Remapping/distributed_remapping.jl Show resolved Hide resolved
@Sbozzolo Sbozzolo force-pushed the ck/vert_remapper branch 3 times, most recently from f06dd09 to d7f988d Compare January 7, 2025 19:43
@Sbozzolo @charleskawczynski
Various improvements to Remapper
69c02ac 
This commit:
- extends the remapper to work with purely vertical spaces
- adds documentation about remapping
- adds user-facing functions to directly remap a field

Co-authored-by: charleskawczynski <[email protected]>
@Sbozzolo Sbozzolo enabled auto-merge January 8, 2025 19:21
@charleskawczynski
Copy link
Member Author

This build effectively passed: https://buildkite.com/clima/climacore-ci/builds/4890

@charleskawczynski charleskawczynski merged commit b099c3e into main Jan 8, 2025
33 of 34 checks passed
@charleskawczynski charleskawczynski deleted the ck/vert_remapper branch January 8, 2025 22:00
@imreddyTeja imreddyTeja mentioned this pull request Jan 13, 2025
Open
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Sbozzolo Sbozzolo Sbozzolo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The remapper does not work for purely vertical spaces
2 participants
@charleskawczynski @Sbozzolo