Add documentation #87
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sbozzolo
requested review from
charleskawczynski,
dennisYatunin and
sriharshakandala
docs/src/internals.md
Outdated
| `Device`s identify a specific type of computing hardware (e.g., a CPU/a NVidia | ||
| GPU, et cetera). The `Device`s implemented are | ||
| - [`CPUSingleThreaded`](@ref), for a CPU core with a single thread; | ||
| - [`CUDADevice`](@ref), for a single CPU core. |
There was a problem hiding this comment.
Suggested change
| - [`CUDADevice`](@ref), for a single CPU core. | |
| - [`CUDADevice`](@ref), for a single CUDA device. |
charleskawczynski
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
This is a nice set of improvements and documentation, thanks @Sbozzolo!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ClimaCommsis an important package in theCliMAecosystem. In particular, it controls how users select whether to run their simulations on CPU or GPUs. It also introduces the concepts ofdeviceandcontextthat are seen everywhere in our codes. In this PR, I try to start filling this gap.