-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor macros, bump patch version #79
Conversation
b7cf03e
to
0a8edda
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! This is good solution (if everything works)
0a8edda
to
b69139c
Compare
b69139c
to
84f091c
Compare
84f091c
to
db9197b
Compare
@@ -26,13 +42,13 @@ If the desired device is CUDA (as determined by `ClimaComms.device()`), try load | |||
""" | |||
macro import_required_backends() | |||
return quote | |||
@static if $mpi_is_required() && $mpi_ext_is_not_loaded() | |||
@static if $mpi_is_required() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed the mpi_ext_is_loaded
check, since it is a no-op. Also, the function says that it will import the required.
Let's try this out. |
This PR refactors the macros to avoid code loading logic inside macros.