Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issues with the macros, introduced in #79.
Using
sin.(AT(rand(1000, 1000)))
in the test suite:So, this appears to fix the issue. I'm not sure what the best way to test this.
Part of the reason is that this PR is technically behavior changing in that the macro now makes an argument-less closure, and times (in the case of
@time
) the closure.I think that this is probably fine and, frankly, we could even eliminate the macro and just make the methods, which are far easier to extend/understand (as there is no hygiene to worry about), user-facing. The purely method-based approaches may be easier to test, too, since we could even check
@which
to ensure that we're calling the extension when we expect.