-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ClimaComms.@elapsed not working correctly on CUDADevice #82
Comments
Sbozzolo
changed the title
ClimaComms.@elapsed not correctly working on CUDADevice
ClimaComms.@elapsed not working correctly on CUDADevice
Jun 6, 2024
Ah, there is a typo here : Line 182 in ae67a34
(Looks internally consistent, however) |
Bummer, can we move this issue to ClimaComms? We should probably add tests for this. Maybe we can inspect the macroexpanded code and make sure that CUDA’s sync is exists. the other macros very well may be broken, too. |
Merged
Closed by #83 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Unfortunately, it looks like that
ClimaComms.@elapsed
is not usingCUDA.@elapsed
. See, for example, https://buildkite.com/clima/climaatmos-ci/builds/19101#018fea6e-9626-4c61-a653-3d72a751a817The text was updated successfully, but these errors were encountered: