Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ClimaComms.@elapsed not working correctly on CUDADevice #82

Closed
Sbozzolo opened this issue Jun 6, 2024 · 3 comments
Closed

ClimaComms.@elapsed not working correctly on CUDADevice #82

Sbozzolo opened this issue Jun 6, 2024 · 3 comments

Comments

@Sbozzolo
Copy link
Member

Sbozzolo commented Jun 6, 2024

Unfortunately, it looks like that ClimaComms.@elapsed is not using CUDA.@elapsed. See, for example, https://buildkite.com/clima/climaatmos-ci/builds/19101#018fea6e-9626-4c61-a653-3d72a751a817

[ Info: sypd: 1.2842464690834364e7
[ Info: wall_time_per_timestep: 22 nanoseconds
@Sbozzolo Sbozzolo changed the title ClimaComms.@elapsed not correctly working on CUDADevice ClimaComms.@elapsed not working correctly on CUDADevice Jun 6, 2024
@akshaysridhar
Copy link
Member

akshaysridhar commented Jun 6, 2024

Ah, there is a typo here :

$(__CC__).cuda_elasped($expr)

(Looks internally consistent, however)

@charleskawczynski
Copy link
Member

Bummer, can we move this issue to ClimaComms? We should probably add tests for this. Maybe we can inspect the macroexpanded code and make sure that CUDA’s sync is exists.

the other macros very well may be broken, too.

@Sbozzolo Sbozzolo transferred this issue from CliMA/ClimaAtmos.jl Jun 6, 2024
@charleskawczynski
Copy link
Member

Closed by #83

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants