Refactor macros, bump patch version #79
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charleskawczynski
force-pushed
the
ck/refactor_macros
branch
from
b7cf03e
to
0a8edda
Compare
Sbozzolo
reviewed
May 30, 2024
charleskawczynski
force-pushed
the
ck/refactor_macros
branch
from
0a8edda
to
b69139c
Compare
charleskawczynski
force-pushed
the
ck/refactor_macros
branch
from
b69139c
to
84f091c
Compare
charleskawczynski
force-pushed
the
ck/refactor_macros
branch
from
84f091c
to
db9197b
Compare
| @@ -26,13 +42,13 @@ If the desired device is CUDA (as determined by `ClimaComms.device()`), try load | |||
| """ | |||
| macro import_required_backends() | |||
| return quote | |||
| @static if $mpi_is_required() && $mpi_ext_is_not_loaded() | |||
| @static if $mpi_is_required() | |||
There was a problem hiding this comment.
I've removed the mpi_ext_is_loaded check, since it is a no-op. Also, the function says that it will import the required.
|
Let's try this out. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the macros to avoid code loading logic inside macros.