Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flag for running updraft massflux implicitly in GM equations #3653

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

costachris
Copy link
Member

Add flag for running updraft massflux implicitly, with grid-mean jacobian terms zero as a placeholder.

@costachris costachris force-pushed the cc/implicit_up_mf_flag branch 2 times, most recently from aa5cdd5 to 52d5a99 Compare February 24, 2025 21:50
@costachris costachris changed the title Add flag for running updraft massflux implicitly Add flag for running updraft massflux implicitly in GM equations Feb 24, 2025
@costachris costachris force-pushed the cc/implicit_up_mf_flag branch from 52d5a99 to c08a64a Compare February 24, 2025 22:44
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be good to use implicit_sgs_mass_flux: true in one of the test cases (e.g. soares).

@costachris costachris force-pushed the cc/implicit_up_mf_flag branch 3 times, most recently from c52fe73 to e4d2f16 Compare February 25, 2025 01:46
@costachris costachris force-pushed the cc/implicit_up_mf_flag branch from e4d2f16 to 16aa9eb Compare February 25, 2025 01:49
@costachris costachris added this pull request to the merge queue Feb 25, 2025
Merged via the queue into main with commit a10f2d7 Feb 26, 2025
15 of 20 checks passed
@costachris costachris deleted the cc/implicit_up_mf_flag branch February 26, 2025 01:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants