Add tests and plots for steady-state velocity #3593
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
This PR adds tests for the steady-state velocity in box setups with analytically-defined topography, as well as plots of errors and level/column averages. Together with #3552, this supercedes #3182.
The changes to the driver are:
"check_steady_state"
flag to the config, which isfalse
by defaultAtmosCache
ConstantBuoyancyFrequencyProfile
initial condition, which is currently required to compute analytic solutionsᶠu
in the precomputed quantities, and use this value in comparisons against analytic solutionsᶠu
instead ofᶜu
, in order to accurately capture behavior at the boundaries@test
for simulations that run for longer than 1 day and can reach steady-stateThe changes to CI are:
ConstantBuoyancyFrequencyProfile
initial condition and the discretization outlined in the dycore paperI'm planning to eventually remove the cosine topography tests, and instead use 3D and extruded 2D versions of the Schar mountain. However, these will take a while to run, so I will add them to the longruns in a future PR.