-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add buildkite project #3561
Add buildkite project #3561
Conversation
5a50f43
to
8b45cbf
Compare
8b45cbf
to
d604c19
Compare
Thank you! I forgot to commit it. Some depedencies are surprising. For example, how are we depending on Also, some of the compats also seem wrong. For example, I don't think we are compatible with SciMLBase 1 or julia 1.7 |
Thank you! |
I left it because people are used to using it, and there is no fundamental problem with having a Project.toml. You can still use it to instantiate your environment locally. |
No idea, this came along when I instantiated the |
I was comparing with the Project.toml I have locally I think that there's something wrong with how you got the dependencies. I see a lot of packages that can be removed (but my Project.toml also has package that can be removed). I'll merge the two lists |
Oh, I see it. It's the examples/Project.toml that has a lot of stuff that is not needed. |
I took a closer look, |
#3563 is failing. Let's tackle these issues incrementally. This PR fixes one. If there are more, let's open issues and tackle the remaining separately. |
This PR adds the buildkite Project.toml (xref, xref).
I actually did this programmatically, and doing so allowed me to delete some direct dependencies:
This unfortunately won't remove packages that are mentioned in julia file doc strings, but I think it was still helpful