Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ci changes needed for the upcoming working fluid PR #3557

Merged
merged 2 commits into from
Jan 31, 2025
Merged

Ci changes needed for the upcoming working fluid PR #3557

merged 2 commits into from
Jan 31, 2025

Conversation

trontrytel
Copy link
Member

This is a peel off from #3536

It:

  • removes support for equilibrium moisture + 1-moment microphysics and nonequilibrium + 0-moment
  • makes the corresponding changes in the CI pipeline

@trontrytel trontrytel requested a review from szy21 January 29, 2025 19:16
@trontrytel trontrytel force-pushed the aj/working_fluid_part1 branch from 7a4a0b1 to 09baeef Compare January 29, 2025 19:21
@trontrytel trontrytel self-assigned this Jan 29, 2025
@trontrytel
Copy link
Member Author

Also waiting for #3542

szy21
szy21 reviewed Jan 29, 2025
View reviewed changes
Project.toml Outdated Show resolved Hide resolved
szy21
szy21 approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@szy21 szy21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can remove diagnostic_edmfx_trmm_box_0m now (and maybe there are some more files you can remove that I missed).

src/parameterized_tendencies/microphysics/microphysics_wrappers.jl Show resolved Hide resolved
config/model_configs/diagnostic_edmfx_trmm_box.yml Show resolved Hide resolved
@trontrytel trontrytel force-pushed the aj/working_fluid_part1 branch 3 times, most recently from a33095f to 90f6695 Compare January 29, 2025 20:55
@trontrytel
Copy link
Member Author

I think I tracked all the relevant tomls... Will clean up some more after the dycore paper

@trontrytel trontrytel force-pushed the aj/working_fluid_part1 branch 3 times, most recently from e9e5c1e to 1c51aa2 Compare January 30, 2025 21:35
@trontrytel trontrytel enabled auto-merge January 30, 2025 21:36
@trontrytel trontrytel disabled auto-merge January 30, 2025 23:04
@trontrytel trontrytel force-pushed the aj/working_fluid_part1 branch 2 times, most recently from 769f03d to a20d1a2 Compare January 31, 2025 00:27
@trontrytel trontrytel force-pushed the aj/working_fluid_part1 branch from a20d1a2 to 00e2ee7 Compare January 31, 2025 01:26
@trontrytel trontrytel enabled auto-merge January 31, 2025 01:27
@trontrytel trontrytel added this pull request to the merge queue Jan 31, 2025
Merged via the queue into main with commit 2ff7b58 Jan 31, 2025
17 of 19 checks passed
@trontrytel trontrytel deleted the aj/working_fluid_part1 branch January 31, 2025 04:08
@szy21 szy21 mentioned this pull request Jan 31, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szy21 szy21 szy21 approved these changes

Assignees

@trontrytel trontrytel

Labels
Microphysics
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@trontrytel @szy21