add different sizes for dust and sea salt #3555
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szy21
force-pushed
the
zs/rrtmgp
branch
4 times, most recently
from
8e7b9c8 to
128c70d
Compare
szy21
force-pushed
the
zs/rrtmgp
branch
3 times, most recently
from
573da3c to
c7f8ab7
Compare
|
@Sbozzolo Could you take a look and see if there is an easy way to support both rrtmgp versions? I'm happy to change it if that's the case. |
szy21
force-pushed
the
zs/rrtmgp
branch
7 times, most recently
from
c7af458 to
5d63709
Compare
Sbozzolo
approved these changes
Feb 5, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
This passed buildkite, and didn't change the ref counter, so I'm going to manually merge it in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Allows five size bins of dust and sea salt which matches RRTMGP after v0.19.2. Also supports RRTMGP before v0.19.2.
This will be merged first to fix downstream test in CliMA/RRTMGP.jl#564. ci build with this rrtmgp branch: https://buildkite.com/clima/climaatmos-ci/builds/22742
To-do
Content