Adding nonequilibrium parameterization to EDMF

[oalcabes]

Purpose

To-do

Content

---

• I have read and checked the items on the review checklist.

[charleskawczynski]

Suggested change

	ᶜq_liq⁰ = similar(Y.c, FT),
	ᶜq_ice⁰ = similar(Y.c, FT),

Can we instead compute these on the fly?

[charleskawczynski]

Suggested change

	@. ᶜq_tot⁰ = divide_by_ρa(
	Y.c.ρq_tot - ρaq_tot⁺(Y.c.sgsʲs),
	ᶜρa⁰,
	Y.c.ρq_tot,
	Y.c.ρ,
	turbconv_model,
	)
	@. ᶜq_liq⁰ = divide_by_ρa(
	Y.c.ρq_liq - ρaq_liq⁺(Y.c.sgsʲs),
	ᶜρa⁰,
	Y.c.ρq_liq,
	Y.c.ρ,
	turbconv_model,
	)
	@. ᶜq_ice⁰ = divide_by_ρa(
	Y.c.ρq_ice - ρaq_ice⁺(Y.c.sgsʲs),
	ᶜρa⁰,
	Y.c.ρq_ice,
	Y.c.ρ,
	turbconv_model,
	)

[charleskawczynski]

Suggested change

	TD.PhasePartition.(ᶜq_tot⁰, ᶜq_liq⁰, ᶜq_ice⁰),
	nonequil_phase_part(ᶜts, Y.c.sgsʲs, ᶜρa⁰, Y.c.ρ, turbconv_model),

and somewhere in the module we can define:

nonequil_phase_part(ts, sgsʲs, ᶜρa⁰, ρ, turbconv_model) =
    nonequil_phase_part(
        ρ * TD.total_specific_humidity(ts),
        ρ * TD.liquid_specific_humidity(ts),
        ρ * TD.ice_specific_humidity(ts),
        sgsʲs, ᶜρa⁰, ρ, turbconv_model
    )
function nonequil_phase_part(ρq_tot, ρq_liq, ρq_ice, sgsʲs, ᶜρa⁰, ρ, turbconv_model)
    q_tot = divide_by_ρa(
        ρq_tot - ρaq_tot⁺(sgsʲs),
        ᶜρa⁰,
        ρq_tot,
        ρ,
        turbconv_model,
    )
    q_liq = divide_by_ρa(
        ρq_liq - ρaq_liq⁺(sgsʲs),
        ᶜρa⁰,
        ρq_liq,
        ρ,
        turbconv_model,
    )
    q_ice = divide_by_ρa(
        ρq_ice - ρaq_ice⁺(sgsʲs),
        ᶜρa⁰,
        ρq_ice,
        ρ,
        turbconv_model,
    )
return TD.PhasePartition(q_tot, q_liq, q_ice)
end

[trontrytel]

Thank you! FYI we have decided to only support 0M + equilibrium or 1M non-equilibrium. I'll try to quickly go through the code we currently have to reflect that change and then look at this PR

[trontrytel]

I'm thinking of putting q_rai and q_sno inside the edmf sub-domains to have simplify the constructor logic. Stay tuned