Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not fitted event counter fix #24

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

tricasthu
Copy link
Contributor

There was a bug in not fitted event counter.

For example, have maxEventLines events from the 5th to the 7th (3 days long each). Add an event from the 7th to the 8th (2 days long). It won't be shown because of how the algorithm works (prioritizes longer events), which is fine. +1 will appear on the 7th, which is also fine. However, +1 won't appear on the 8th, however, it should.

I have modified the implementation a little bit to fix this error. When events are selected to be drawn, they are removed from the original event list. At the end of the event placing algorithm, we can know for sure that leftover events are not shown, and there should be a +1 on each day they take place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants