[SDK-3328] Fix classCastException from while reading PE variable #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…fineVariable API Issue has been fixed by restricting null values as default when defining the PE variables
…ernal Var#define method This adjustment ensures that the condition is applied to annotated variables as well.
Anush-Shand
approved these changes
Dec 22, 2023
|
Unit tests are failing @shivamsharma2710 |
piyush-kukadiya
deleted the
task/SDK-3328/fix_classCastException_in_defineVariable_API
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue Summary:
When a PE variable of
Longtype is defined with a null default value, and the dashboard overrides it with a Double value, The SDK throws a ClassCastException (Double cannot be cast to Long).Fix:
Restricted the null usage as default value for PE variables.