Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(domains/overview): handle wildcard domains properly #849

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(domains/overview): handle wildcard domains properly #849

wants to merge 1 commit into from

Conversation

florian-sanders-cc
Copy link
Contributor

Fixes #847

What does this PR do?

  • Fixes the error thrown when dealing with wildcard domains

How to review?

  • Check the commit,
  • Test the clever domain overview command with at least one wildcard domain used in one of your orgs.

@florian-sanders-cc florian-sanders-cc requested a review from a team as a code owner November 13, 2024 10:15
@github-actions GitHub Actions
Copy link

🔎 A preview has been automatically published:

  • 🐧 linux 75b92df8a8ac05e83a32696164e524477b43547e0480e34d76e0840a91cd6929
  • 🍏 macos 2fcc48a3909b09501956a169888f8c97f7df6091023189ff25e964070168ecd0
  • 🪟 win 266456b8f92c53056ee7e04d15e816cec3f65cad39a8ed081d69033aaac68247

This preview will be deleted once this PR is closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@hsablonniere hsablonniere

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Issue with clever domain overview and wildcard domains.
2 participants
@florian-sanders-cc @hsablonniere