Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(addon): enable string value for defined option keys #824

Merged
merged 1 commit into from
Oct 16, 2024
Merged

feat(addon): enable string value for defined option keys #824

merged 1 commit into from
Oct 16, 2024

Conversation

aurrelhebert
Copy link
Member

@aurrelhebert aurrelhebert commented Sep 12, 2024 •
edited by hsablonniere
Loading

TODO

  • rebase on rework
  • allow any string

@aurrelhebert aurrelhebert requested a review from a team as a code owner September 12, 2024 14:59
@github-actions GitHub Actions
Copy link

github-actions bot commented Sep 12, 2024 •
edited
Loading

🔎 A preview has been automatically published:

  • 🐧 linux c68b63c81106309c7668b6fa137cdd953aec8335076b7332d994e2f9639a5706
  • 🍏 macos 6a88afd667c692147efd8b187b62af6bc757f80558beb8ddd8a780365629a568
  • 🪟 win ed9f5c820afad693250d312eb8abd6e3e3f3f8df91333d0a337035b7b7b568a3

This preview will be deleted once this PR is closed.

@hsablonniere hsablonniere added this to the 3.9.0 milestone Oct 9, 2024
@hsablonniere hsablonniere merged commit 81b01d3 into master Oct 16, 2024
5 checks passed
@hsablonniere hsablonniere deleted the feat/options/locale branch October 16, 2024 16:42
@github-actions GitHub Actions
Copy link

🔎 The preview has been automatically deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hsablonniere hsablonniere hsablonniere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aurrelhebert @hsablonniere