Revamp UI #9
Open
Revamp UI #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you!
|
- Remove most constraints, use stack views instead - Remove NoClippingView, which isn't needed when building with Sonoma SDKs and up - Simplify the show/hide code to only hide the stack views themselves, and remove the associated outlets
The system doesn't seem to provide a large image for the warning triangle, so we're getting it from the system Diagnostics Reporter app.
- Window title and body title now mention app name - Some of the text has been reworded, some removed - Elements are reordered
The privacy policy button is hidden alongside the crash log. The window is now narrower.
- Fix email field placeholder not showing, and reword - Make title text size standard
And bold the field labels.
- Updated screenshots - Mention userProvidedDetails POST variable
|
I modeled the UI after the built-in macOS crash reporter; so I went along with their "Show/Hide Details" button, and the way it reveals the details inline: That's also where I moved the privacy policy button, which didn't fit in the button row anymore. A disclosure arrow might make more sense, but might also look less familiar, and make the window feel more cluttered because of how it would stand out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR completely revamps the crash reporter UI, and adds the ability for the user to provide details about the crash.
The main changes are: