Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix lint errors in datacube script #36

Merged
merged 8 commits into from
Nov 16, 2023
Merged

Fix lint errors in datacube script #36

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
7fd0939
:rotating_light: Fix E501 Line too long
weiji14 Nov 15, 2023
cc99ae4
:recycle: Refactor best_nodata and best_clouds into single sort function
weiji14 Nov 15, 2023
262aaa6
:ambulance: Quickfix with getting the STAC item with a specific datetime
weiji14 Nov 15, 2023
2af24be
:label: Rename variables to ds_ (xr.Dataset) or da (xr.DataArray)
weiji14 Nov 15, 2023
4664b59
:wrench: Set pylint max-args to 6
weiji14 Nov 15, 2023
a396c5d
:wastebasket: Replace .get_all_items() with .item_collection()
weiji14 Nov 15, 2023
f65e34a
:fire: Remove sorting by nodata and just sort by least cloud cover
weiji14 Nov 16, 2023
7b20878
:memo: More DataArray to Dataset renames
weiji14 Nov 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@ select = [
"UP", # pyupgrade
"W", # pycodestyle warnings
]

[tool.ruff.lint.pylint]
max-args = 6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increasing the maximum allowed arguments to functions from the default of 5 to 6, to avoid these errors:

scripts/datacube.py:293:5: PLR0913 Too many arguments in function definition (6 > 5)
scripts/datacube.py:428:5: PLR0913 Too many arguments in function definition (6 > 5)

Alternatively, we could look at simplifying those functions to have less arguments.

Loading