-
Notifications
You must be signed in to change notification settings - Fork 848
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding tests CI #503
Merged
Merged
Adding tests CI #503
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
04bc441
to
16f77aa
Compare
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
44143f5
to
47c87d7
Compare
47c87d7
to
d421cd2
Compare
6dbc9eb
to
7c9206d
Compare
cd3cae4
to
1414875
Compare
# Conflicts: # .github/workflows/test-CI.yml
…ased on target branch
6914408
to
7c33180
Compare
4d51661
to
7525a5c
Compare
7525a5c
to
33e011b
Compare
GilClassiq
reviewed
Oct 22, 2024
tests/utils_for_tests.py
Outdated
notebooks_to_test = os.environ.get("LIST_OF_IPYNB_CHANGED", "").split() | ||
else: | ||
notebooks_to_test = [] | ||
# if os.environ.get("HAS_ANY_IPYNB_CHANGED", "") == "true": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
REMOVE THE COMMENTSSSSSS
GilClassiq
approved these changes
Oct 28, 2024
a9d4cb0
to
024e9db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Some notes
Please make sure that you placed the files in an appropriate folder
And that the files have indicative names.
Please note that Classiq runs automatic code linting, which may minorly alter some files.
pre-commit
, you may runpre-commit install
, and then at each commit, your files will be altered in a similar way