Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding tests CI #503

Merged
merged 17 commits into from
Oct 28, 2024
Merged

Adding tests CI #503

merged 17 commits into from
Oct 28, 2024

Conversation

NadavClassiq
Copy link
Collaborator

PR Description

Some notes

  • Please make sure that you placed the files in an appropriate folder

  • And that the files have indicative names.

  • Please note that Classiq runs automatic code linting, which may minorly alter some files.

    • If you're familiar with pre-commit, you may run pre-commit install, and then at each commit, your files will be altered in a similar way

@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 2 times, most recently from 04bc441 to 16f77aa Compare October 8, 2024 14:25
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 3 times, most recently from 44143f5 to 47c87d7 Compare October 9, 2024 07:34
@NadavClassiq NadavClassiq reopened this Oct 9, 2024
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch from 47c87d7 to d421cd2 Compare October 9, 2024 07:39
@NadavClassiq NadavClassiq reopened this Oct 9, 2024
@NadavClassiq NadavClassiq reopened this Oct 9, 2024
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 13 times, most recently from 6dbc9eb to 7c9206d Compare October 10, 2024 09:08
@NadavClassiq NadavClassiq reopened this Oct 10, 2024
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 2 times, most recently from cd3cae4 to 1414875 Compare October 10, 2024 12:00
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 3 times, most recently from 6914408 to 7c33180 Compare October 22, 2024 10:38
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch 2 times, most recently from 4d51661 to 7525a5c Compare October 22, 2024 12:26
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch from 7525a5c to 33e011b Compare October 22, 2024 12:43
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test_scheduled.yml Show resolved Hide resolved
notebooks_to_test = os.environ.get("LIST_OF_IPYNB_CHANGED", "").split()
else:
notebooks_to_test = []
# if os.environ.get("HAS_ANY_IPYNB_CHANGED", "") == "true":
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

REMOVE THE COMMENTSSSSSS

@NadavClassiq NadavClassiq changed the title Adding tests infrastructures Adding tests CI Oct 27, 2024
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
.github/workflows/test-CI.yml Outdated Show resolved Hide resolved
@NadavClassiq NadavClassiq force-pushed the CAD-22795-restore-changes branch from a9d4cb0 to 024e9db Compare October 28, 2024 07:11
@NadavClassiq NadavClassiq merged commit 0cbe355 into main Oct 28, 2024
2 of 3 checks passed
@classiqdor classiqdor deleted the CAD-22795-restore-changes branch November 28, 2024 10:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants