Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings #1433

Closed
wants to merge 3 commits into from
Closed

Fix deprecation warnings #1433

wants to merge 3 commits into from

Conversation

DamyanBG
Copy link

Fix #1426

Description

I filtered out deprecation warnings and now they are not visible.

@brylie
Copy link
Member

brylie commented Oct 14, 2022

@DamyanBG, thank you for this pull request.

Disabling all deprecation warnings may be a bit of a big hammer for this issue since deprecation warnings help warn us about parts of the code that will not function after a specified time.

I found an upstream bug report in the django-notifications-hq project related to the specific deprecation warnings from issue #1426:

django-notifications/django-notifications#344

@brylie brylie closed this Oct 14, 2022
@brylie
Copy link
Member

brylie commented Oct 14, 2022

I've closed this PR since we want to keep deprecation warnings working. Also, it seems like the solution will be to fix the code in the upstream django-notifications package, which I'm not sure we can commit to doing.

@DamyanBG
Copy link
Author

@DamyanBG, thank you for this pull request.

Disabling all deprecation warnings may be a bit of a big hammer for this issue since deprecation warnings help warn us about parts of the code that will not function after a specified time.

I found an upstream bug report in the django-notifications-hq project related to the specific deprecation warnings from issue #1426:

django-notifications/django-notifications#344

Yes, I opened the issue.

@brylie
Copy link
Member

brylie commented Oct 14, 2022

lol I didn't notice that :-)

OK, do you think we should try to help resolve that issue upstream? Also, what do you think about discussion #1434?

@DamyanBG
Copy link
Author

I will take a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix notifications deprecation errors
2 participants