Accounts templates django syntax #1428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
brylie
force-pushed
the
accounts-templates-django-syntax
branch
from
d8b4ff7
to
77c5df9
Compare
|
First of all, you did a great job here. That is really a huge effort. 😄 |
gorkemarslan
requested changes
Oct 19, 2022
project/accounts/templates/accounts/partials/user_civis_list.html
Outdated
Show resolved
Hide resolved
project/accounts/templates/accounts/partials/user_followers_list.html
Outdated
Show resolved
Hide resolved
project/accounts/templates/accounts/partials/user_threads_list.html
Outdated
Show resolved
Hide resolved
gorkemarslan
requested changes
Oct 20, 2022
gorkemarslan
requested changes
Oct 21, 2022
|
Nicely done, @brylie! Just one comment then I will approve it. 🥳 |
gorkemarslan
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request takes a step back, feature-wise, so we can take some steps forward. The JavaScript code is a significant blocker, so this pull request removes the blocking code/complexity.
My goal is to remove the
accounts.jsBackbone JS while preserving templates and view code. That way, we can re-implement the features as a community, possibly during Hacktoberfest 🎃Closes #1151
The work can now continue to reimplement the profile sections.
Changes
reverse_nameproperties on foreign keysContinuing work
The work to improve the user profile and feed views will continue in the following epic #1429