Add comments into config.yml #31
Conversation
Added comments for most of the config options. I am unsure what EnderPearl's scaleFac does.
|
Thanks for adding this, the documentation of Bastion is kinda sketchy Ender pearl scale fac is how much damage a pearl deals to the bastion. Also could you sign the CLA, it can't be merged before that. |
|
As compared to how much it would do if someone placed a block. On Fri, Oct 16, 2015 at 7:10 AM Max Baumstark [email protected]
|
|
Signed. |
|
Could you add a line for enderpearl scaleFac? |
| blocksToErode: 1 | ||
| # how many bastions break when a field is breached. set to 0 to destroy all overlapping bastions. |
There was a problem hiding this comment.
You need to set this to a negative number if you want all the overlapping bastions to lose durability. Setting this to 0 will cause bastions to be unbreakable. Please fix.
There was a problem hiding this comment.
It also refers to the number of blocks damage gets applied to when someone places a block (or maybe also tries to teleport though I think there can only be one blocking field for that in the code), not how many get destroyed when the field is broken.
There was a problem hiding this comment.
Yeah your explanation of the setting is much better.
There was a problem hiding this comment.
blocks to erode shoudl be negative? I need to check that in the live
config, had some complaints earlier this week.
On Sun, Oct 18, 2015 at 2:58 PM, BlackXnt [email protected] wrote:
In Bastion/config.yml
#31 (comment):blocksToErode: 1
+# how many bastions break when a field is breached. set to 0 to destroy all overlapping bastions.Yeah this is a much better way of explaining it^
—
Reply to this email directly or view it on GitHub
https://github.com/Civcraft/Bastion/pull/31/files#r42327089.
There was a problem hiding this comment.
I double checked, but it looks like it. https://github.com/Civcraft/Bastion/blob/master/Bastion/src/isaac/bastion/manager/BastionBlockManager.java#L67
There was a problem hiding this comment.
sure, should I just pull and then push or do you suggest a different method?
There was a problem hiding this comment.
If you don't want to pull the repo you can edit the file through the browser(by clicking on the edit button in the page of the file) and copy-paste what you have on the server, just make sure you keep the yml format right. the outcome will be the same.
|
You should be placing comments in the top part of the file, before any uncommented text. Otherwise the comments will be deleted if the plugin edits the file (e.g a command that changes the value of one of the settings and requires the plugin to edit the file and save it). |
|
@BlackXnt can you explain more what you mean by your last comment? |
|
Can one of the admins verify this patch? Type 'ok to test' to test. |
Added comments for most of the config options. I am unsure what EnderPearl's scaleFac does.